Skip to content

Commit b1dfdff

Browse files
madhum031gregkh
authored andcommitted
usb: typec: ucsi: Pass full DP config payload in SET_NEW_CAM for DP alt mode
commit 735a461 upstream. In the UCSI Specification Revision 3.1 RC1, bits 32-63 of the SET_NEW_CAM command hold the 32-bit Alternate Mode Specific (AMSpecific) field. For DisplayPort Alternate Mode, this field must contain the full 32-bit DisplayPort configuration VDO payload that the OPM wants the connector to operate in, rather than just the pin assignment value. This AMSpecific value follows the DisplayPort Configurations defined in the DisplayPort Alt Mode on USB Type-C Specification v2.1a, Table 5-13: SOP DisplayPort Configurations. Fixes: af8622f ("usb: typec: ucsi: Support for DisplayPort alt mode") Cc: stable <stable@kernel.org> Signed-off-by: Madhu M <madhu.m@intel.com> Reviewed-by: Jameson Thies <jthies@google.com> Reviewed-by: Andrei Kuchynski <akuchynski@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://patch.msgid.link/20260619153311.3526083-1-madhu.m@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8c00aec commit b1dfdff

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/usb/typec/ucsi/displayport.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,12 @@ static int ucsi_displayport_status_update(struct ucsi_dp *dp)
185185

186186
static int ucsi_displayport_configure(struct ucsi_dp *dp)
187187
{
188-
u32 pins = DP_CONF_GET_PIN_ASSIGN(dp->data.conf);
189188
u64 command;
190189

191190
if (!dp->override)
192191
return 0;
193192

194-
command = UCSI_CMD_SET_NEW_CAM(dp->con->num, 1, dp->offset, pins);
193+
command = UCSI_CMD_SET_NEW_CAM(dp->con->num, 1, dp->offset, dp->data.conf);
195194

196195
return ucsi_send_command(dp->con->ucsi, command, NULL, 0);
197196
}

0 commit comments

Comments
 (0)