Skip to content

Commit c86fc47

Browse files
Ming Leigregkh
authored andcommitted
block: add helper add_disk_final()
[ Upstream commit 5fad149 ] Add helper add_disk_final() for scanning partitions, announcing disk and handling the last thing for adding disk. No functional change, and prepare for prevent adding disk from happening when updating nr_hw_queues. Signed-off-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20250505141805.2751237-8-ming.lei@redhat.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Stable-dep-of: 181bb9c ("block: remove redundant GD_NEED_PART_SCAN in add_disk_final()") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8016a7d commit c86fc47

1 file changed

Lines changed: 27 additions & 19 deletions

File tree

block/genhd.c

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,32 @@ int disk_scan_partitions(struct gendisk *disk, blk_mode_t mode)
382382
return ret;
383383
}
384384

385+
static void add_disk_final(struct gendisk *disk)
386+
{
387+
struct device *ddev = disk_to_dev(disk);
388+
389+
if (!(disk->flags & GENHD_FL_HIDDEN)) {
390+
/* Make sure the first partition scan will be proceed */
391+
if (get_capacity(disk) && disk_has_partscan(disk))
392+
set_bit(GD_NEED_PART_SCAN, &disk->state);
393+
394+
bdev_add(disk->part0, ddev->devt);
395+
if (get_capacity(disk))
396+
disk_scan_partitions(disk, BLK_OPEN_READ);
397+
398+
/*
399+
* Announce the disk and partitions after all partitions are
400+
* created. (for hidden disks uevents remain suppressed forever)
401+
*/
402+
dev_set_uevent_suppress(ddev, 0);
403+
disk_uevent(disk, KOBJ_ADD);
404+
}
405+
406+
blk_apply_bdi_limits(disk->bdi, &disk->queue->limits);
407+
disk_add_events(disk);
408+
set_bit(GD_ADDED, &disk->state);
409+
}
410+
385411
/**
386412
* device_add_disk - add disk information to kernel list
387413
* @parent: parent device for the disk
@@ -500,21 +526,6 @@ int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
500526
&disk->bdi->dev->kobj, "bdi");
501527
if (ret)
502528
goto out_unregister_bdi;
503-
504-
/* Make sure the first partition scan will be proceed */
505-
if (get_capacity(disk) && disk_has_partscan(disk))
506-
set_bit(GD_NEED_PART_SCAN, &disk->state);
507-
508-
bdev_add(disk->part0, ddev->devt);
509-
if (get_capacity(disk))
510-
disk_scan_partitions(disk, BLK_OPEN_READ);
511-
512-
/*
513-
* Announce the disk and partitions after all partitions are
514-
* created. (for hidden disks uevents remain suppressed forever)
515-
*/
516-
dev_set_uevent_suppress(ddev, 0);
517-
disk_uevent(disk, KOBJ_ADD);
518529
} else {
519530
/*
520531
* Even if the block_device for a hidden gendisk is not
@@ -523,10 +534,7 @@ int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
523534
*/
524535
disk->part0->bd_dev = MKDEV(disk->major, disk->first_minor);
525536
}
526-
527-
blk_apply_bdi_limits(disk->bdi, &disk->queue->limits);
528-
disk_add_events(disk);
529-
set_bit(GD_ADDED, &disk->state);
537+
add_disk_final(disk);
530538
return 0;
531539

532540
out_unregister_bdi:

0 commit comments

Comments
 (0)