Test-name fixes#139
Merged
mpirnat merged 2 commits intogregmalcolm:masterfrom Sep 30, 2016
Merged
Conversation
In the Python 3 version, the function test_set_descriptor_changes_behavior_of_attribute_assignment was named: test_set_descriptor_changes_behavior_of_attribute_assignment_changes --- with an extra "_changes" at the end. Renamed it to match the more sensible Python 2 version's name.
Removed extra 'this_' left over from the Python 2 version of test: test_this_all_classes_in_python_3_ultimately_inherit_from_object_class renamed to: test_all_classes_in_python_3_ultimately_inherit_from_object_class.
Collaborator
|
Thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two test name typos (both appeared only in the Python 3 files):
test_this_all_classes_in_python_3_ultimately_inherit_from_object_class->test_all_classes_in_python_3_ultimately_inherit_from_object_classtest_set_descriptor_changes_behavior_of_attribute_assignment_changes->test_set_descriptor_changes_behavior_of_attribute_assignment