Unmockify

[kjc]

Python 2 and 3: Replaces several <globally_visible_thing> = Mock() assignments with with patch(...): and with patch_object(...): blocks, to prevent Mock objects leaking out of their tests into others.

For example, after test_mountain or test_sensei ran path_to_enlightenment.koans = Mock(), it was impossible to test the koans function --- it just kept returning Mock. (That specific mock seemed completely unneeded anyway, so I removed it. The _runner_tests.py outputs didn't change.)

[kjc]

I encountered this because I was trying to test a version of path_to_enlightenment.koans that imports and loads koans based on the name of the module. It's uglier than I wanted (because about_proxy_object_project.TelevisionTest doesn't fit the pattern), but it might still be easier to manage than dozens-of-imports followed by dozens-of-addTests. Since it's arguments are just a bunch of strings, they could conceivably be moved to an external config file.

Is there any interest in this? (I'm not sure if there's a better place to ask this kind of question. Issues, maybe?)

[mpirnat]

I'd be interested to see what your alternative path_to_enlightenment looks like... It definitely seems like the intent is to be able to run them in an arbitrary/non-alphabetic order. It'd probably be good to move discussion to a separate issue.

Thanks for the PR! :-)