Conversation
gregology
approved these changes
Mar 8, 2026
gregology
added a commit
that referenced
this pull request
Mar 9, 2026
…known-tool Add tests for Write-on-existing-file and unknown tool name paths in resolveAction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
resolveActionhas three branches: thetoolToActionmap lookup, theWritetool special case (which checksos.Statto pick between create and edit), and the fallback that returnsActionAllfor unknown tools. Only the Write-as-create path had test coverage.This adds two tests:
TestHandleClaudeHook_WriteExistingFile— Write targeting a file that already exists on disk. Verifies thatos.Statsucceeds and we getActionEdit, so edit-scoped context shows up and create-scoped context doesn't.TestHandleClaudeHook_UnknownToolName— An unrecognized tool name like"UnknownTool"hits theActionAllfallback. Verifies that entries withon: allmatch while entries with specificonvalues (likeon: edit) don't.The issue also suggested testing Write with an unresolvable path (permission denied on stat). I skipped that one — it's basically the same as the existing
TestHandleClaudeHook_WriteNewFilesince anyos.Staterror falls through toActionCreate. Manufacturing a reliable permission-denied scenario in a cross-platform test felt like more trouble than the coverage was worth.Stuck with individual test functions rather than converting to table-driven. The existing tests each need slightly different setup (different AGENTS.yaml content, different file states), so a shared table would mostly just add indirection without reducing code.
Resolves #17