Remove deprecated install:copytree command#39
Merged
Conversation
- Add babel-plugin-transform-import-meta v2.3.3 to devDependencies - Required for ESM import.meta transformation in Jest tests - Fixes missing module error in E2E test suite
- Remove install:copytree command registration from CLI - Delete InstallView.js component (~390 lines) - Remove InstallView import and route from App.js - Update documentation to explain automatic directory creation - Add error handling for cache directory creation failures - Add CommandError for repository cache creation failures - Fix incorrect default format claims in docs (XML not Markdown) - Add regression test to prevent command reintroduction - Update golden file for tree output after file deletion
🤖 Generated with GitHub Actions Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Add context noting format command should be used when formatting is requested - Prevent automatic formatting without explicit user request
- Define skippedFiles variable in StreamingOutputStage SARIF formatter - Add normalization for byte counts in square brackets to handle platform line ending differences - Update tree format golden file to use normalized byte count placeholder - Ensures E2E tests pass consistently across Linux, macOS, and Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated
install:copytreecommand which provided no functional value since all directories are auto-created on first use. The change simplifies the user experience by eliminating an unnecessary installation wizard.Closes #26
Changes Made
Context & Rationale
install:copytreecommand provides no functional value - all directories are auto-created on first useImplementation Details
fs.ensureDirSync(this.cachePath)for cache directoryfs.ensureDirSync(this.cacheDir)for repos directoryBreaking Changes & Migration
Breaking Changes:
install:copytreecommand entirelycopytree install:copytreewill now see "unknown command" errorMigration:
Documentation Updates
Test Updates
Review Fixes
Post-implementation review identified and fixed several robustness issues:
ensureDirSync()to gracefully disable cache on permission errors with helpful error messageensureDirSync()to throw CommandError with helpful guidance on permission failures