Skip to content

Fix error messages that still say "when ... of" #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

Fix error messages that still say "when ... of" #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/src/Reporting/Error/Syntax.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3988,7 +3988,7 @@ noteForCaseError =
[ D.toSimpleNote $
"Here is an example of a valid `when` expression for reference.",
D.vcat $
[ D.indent 4 $ D.fillSep [D.cyan "when", "maybeWidth", D.cyan "of"],
[ D.indent 4 $ D.fillSep [D.cyan "when", "maybeWidth", D.cyan "is"],
D.indent 6 $ D.fillSep [D.blue "Just", "width", "->"],
D.indent 8 $ D.fillSep ["width", "+", D.dullyellow "200"],
"",
Expand All @@ -4007,7 +4007,7 @@ noteForCaseIndentError =
"Sometimes I get confused by indentation, so try to make your `when` look\
\ something like this:",
D.vcat $
[ D.indent 4 $ D.fillSep [D.cyan "when", "maybeWidth", D.cyan "of"],
[ D.indent 4 $ D.fillSep [D.cyan "when", "maybeWidth", D.cyan "is"],
D.indent 6 $ D.fillSep [D.blue "Just", "width", "->"],
D.indent 8 $ D.fillSep ["width", "+", D.dullyellow "200"],
"",
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/Reporting/Error/Type.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ toPatternReport source localizer patternRegion category tipe expected =
tipe
expectedType
(addPatternCategory "The first pattern is trying to match" category)
"But the expression between `when` and `of` is:"
"But the expression between `when` and `is` is:"
[ D.reflow $
"These can never match! Is the pattern the problem? Or is it the expression?"
]
Expand Down
Loading