Add support for deriving bits with the PBKDF2 algorithm#131
Merged
robinheghan merged 1 commit intoMay 20, 2026
Conversation
Member
|
This was a pleasure to review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing some authentication work and would like to save passwords to a database. The existing
Cryptomodule has support for hashing, but strait SHA hashing is not suitable for safely storing passwords as they are vulnerable to various attacks.This PR adds support for the PBKDF2 algorithm to the
Cryptomodule for hashing and saving passwords to a database more safely. Note that while Argon2 (a better password hashing function) is supported by the Node Web Crypto library, it's only available in later versions (v24.8.0) that are not supported by Gren.Tests are included and all tests pass locally on my machine.