Improve update error handling with TTY detection#74
Merged
Conversation
- Add fetchLatestVersionWithDetails() to return detailed error info including HTTP status codes - Show specific error messages for 504 (Gateway Timeout) and 403 (rate limit) errors - Only display error messages when running in interactive TTY mode - Increase fetch timeout from 3s to 5s to reduce false timeouts - Silently exit with code 1 in non-TTY mode (CI/scripts)
|
|
||
| if (!result.version) { | ||
| // Only show detailed error messages in interactive mode (TTY) | ||
| if (process.stdout.isTTY) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Use process.stderr.isTTY instead of stdout.isTTY since errors go to stderr - Format code with oxfmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perry updatefailures (504, 403, timeouts, etc.)Changes
src/update-checker.tsFetchVersionResultinterface withversion,error, andstatusfieldsfetchLatestVersionWithDetails()for detailed error infofetchLatestVersion()as backward-compatible wrappersrc/index.tsprocess.stdout.isTTYto detect interactive modeBehavior