fix: make sync reliably update worker version#99
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| const health = (await response.json().catch(() => null)) as { version?: string } | null; | ||
| if (health?.version === desiredVersion) { | ||
| return; | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/local/bin/perry(avoid PATH shadowing from old~/.npm-global/bin/perry).~/.local/bin/perry -> /usr/local/bin/perryto makeperryinside containers resolve to the synced binary./healthmatches the expected version.perry sync(and the post-update sync) to avoid client-side 30s timeouts when syncing many workspaces.Repro / Verification
workspace-perry5previously had worker stuck on0.3.13due to PATH shadowing; after sync it reports the updated version viahttp://127.0.0.1:7392/health.