Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpgrades skia-safe to 0.91.0 and consistently migrates path construction from mutable Path APIs to skia_safe::PathBuilder, replacing in-place transforms with functional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🧰 Additional context used🧠 Learnings (16)📓 Common learnings📚 Learning: 2025-12-01T00:22:28.164ZApplied to files:
📚 Learning: 2025-12-01T00:22:06.800ZApplied to files:
📚 Learning: 2025-12-01T00:22:36.510ZApplied to files:
📚 Learning: 2025-12-01T00:22:19.083ZApplied to files:
📚 Learning: 2025-12-01T00:22:06.800ZApplied to files:
📚 Learning: 2025-12-01T00:22:28.164ZApplied to files:
📚 Learning: 2025-12-01T00:22:06.800ZApplied to files:
📚 Learning: 2025-12-01T00:22:06.800ZApplied to files:
📚 Learning: 2025-12-01T00:22:19.083ZApplied to files:
📚 Learning: 2025-12-01T00:22:19.083ZApplied to files:
📚 Learning: 2025-12-01T00:22:06.800ZApplied to files:
📚 Learning: 2025-12-01T00:22:19.083ZApplied to files:
📚 Learning: 2025-12-01T00:22:36.510ZApplied to files:
📚 Learning: 2025-12-01T00:22:28.164ZApplied to files:
📚 Learning: 2025-12-01T00:21:48.564ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
crates/grida-canvas/src/shape/srrect_orthogonal.rs (1)
87-209: Removebuilder.arc_to()calls—this method does not exist onPathBuilderin skia-safe 0.91.0.The migration to
PathBuilderis incomplete. Whilemove_to,line_to, andcubic_toexist onPathBuilder,arc_tois only available on the mutablePathtype in skia-safe 0.91.0. Lines 126, 154, 177, and 199 usebuilder.arc_to(), which will fail to compile.Revert this function to use mutable
Path::new()or refactor the arc drawing to use an alternative approach compatible withPathBuilder(e.g., tessellating the arc into cubic Bézier curves).crates/grida-canvas/examples/golden_boolop.rs (1)
73-82: Golden output directory creation is inconsistent with the write target path.
create_dir_all("goldens")depends on CWD, but the write usesCARGO_MANIFEST_DIR/goldens/...; this can fail when run from workspace root.- std::fs::create_dir_all("goldens").unwrap(); - std::fs::write( - concat!(env!("CARGO_MANIFEST_DIR"), "/goldens/boolop.png"), - data.as_bytes(), - ) - .unwrap(); + let goldens_dir = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("goldens"); + std::fs::create_dir_all(&goldens_dir).unwrap(); + std::fs::write(goldens_dir.join("boolop.png"), data.as_bytes()).unwrap();crates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rs (2)
160-167: Embedded font is not registered with theFontCollection—useTypefaceFontProviderinstead.The created
Typefaceis stored but never registered. To make the embedded Geist font available to text layout, create aTypefaceFontProvider, callregister_typeface()with the created typeface, and attach that provider to theFontCollection. The current pattern of setting a default font manager without explicit typeface registration will not resolve the font family name, especially in WASM where system fonts are unavailable.let provider = TypefaceFontProvider::new(); let typeface = font_mgr .new_from_data(&Data::new_copy(cg::fonts::embedded::geist::BYTES), None) .expect("Failed to create typeface"); provider.register_typeface(&typeface); font_collection.set_asset_font_manager(Some(provider));
180-216: Fix non-existent API calls and mutable reference requirements inparagraph_to_pathfunction.The code contains critical compilation errors that go beyond API semantic concerns:
Line 200:
builder.add_path_with_transform()does not exist in skia-safe 0.91.0. The correct API isPath::add_path_matrix(src: &Path, matrix: &Matrix, mode: impl Into<Option<AddPathMode>>). You need to call this on thePathobject, notPathBuilder.Line 213:
path.make_transform(&transform)is called on an immutable reference, but the method signature requires&mut self. The path must be declared as mutable.The double-transform logic (combining glyph positions + origin at line 199, then applying final
(x, y)offset at line 212) is correct in intent but requires the API fixes above.
🧹 Nitpick comments (10)
crates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs (1)
509-516: Tighten readability (and avoid a long single line) around per-glyph transforms.
This is fine functionally, but splitting the matrix creation improves clarity and makes it easier to tweak later (e.g., if you need additional transforms).if let Some(glyph_path) = font.get_path(*glyph) { let offset = Point::new( pos.x + run_origin.x + origin.x, pos.y + run_origin.y + origin.y, ); - builder.add_path_with_transform(&glyph_path, &Matrix::translate((offset.x, offset.y)), None); + let m = Matrix::translate((offset.x, offset.y)); + builder.add_path_with_transform(&glyph_path, &m, None); }crates/grida-canvas/src/shape/ellipse_ring.rs (1)
13-35: Make outer oval direction explicit + validateinner_radius_ratioTo avoid relying on library defaults (and to match the “clockwise” comment), I’d suggest being explicit about winding, and optionally clamping or asserting the documented range:
pub fn build_ring_path(shape: &EllipticalRingShape) -> skia_safe::Path { let mut builder = skia_safe::PathBuilder::new(); + debug_assert!((0.0..=1.0).contains(&shape.inner_radius_ratio)); // ... - builder.add_oval(outer_rect, None, None); + builder.add_oval(outer_rect, Some(skia_safe::PathDirection::CW), Some(0));crates/grida-canvas/src/shape/ellipse_ring_sector.rs (1)
61-98: Builder conversion seems faithful; please sanity-checkarc_tosemantics with negative sweepThe migration reads correct (move_to → arc_to → inner path → close → detach), but because correctness hinges on Skia’s
arc_tobehavior—especially-sweep_degfor the inner arc—I’d recommend confirming output parity (CW/CCW & hole fill) with a quick render/golden test for a few angles (e.g., 90°, 270°, negative sweep).Also applies to: 109-170, 181-269
crates/grida-canvas/src/painter/text_stroke.rs (1)
27-42: VerifyPathBuilder::add_pathAPI/semantics; consider avoiding per-glyphmake_transformif builder supports transformsMain thing to verify is that
builder.add_path(&path)is the intended 0.91.0 API and preserves the previous “append” behavior (previously you hadAddPathModein play). If PathBuilder supports adding with an offset/matrix directly, that’d likely be preferable to allocating a transformedPathper glyph.crates/grida-canvas/src/shape/stroke_rect.rs (2)
263-277: Solid-stroke ring creation via builder-detach is OK; consider de-duplicating the rrect→path boilerplate.A small local helper like
fn path_from_rrect(rr: RRect) -> Pathwould remove repeated builder setup and reduce churn in future edits.
356-373: Clipping ring paths rebuilt via PathBuilder is correct; same de-duplication suggestion applies here.crates/grida-canvas/src/svg/from_usvg_tree.rs (1)
220-228: Immutability change is good; avoid shadowingpathfor readability.Consider:
- let path = path.make_offset((-bounds.x, -bounds.y)); - let data = path.to_svg(); + let offset_path = path.make_offset((-bounds.x, -bounds.y)); + let data = offset_path.to_svg();crates/grida-canvas/src/painter/painter.rs (2)
284-306: Backdrop-blur glyph path accumulation looks correct; watch for per-glyph allocation costs.If skia-safe 0.91 exposes an “add path with matrix/offset” API on
PathBuilder, consider using it to avoidglyph_path.make_transform(...)per glyph.
956-974: Mask-path recursion works, butdetach()/new_path()in the loop may be costly.If this shows up in profiles, a common pattern is: recurse into a fresh
Path, thenbuilder.add_path(&nested)(instead of rebuilding the builder from a detached path each time).crates/grida-canvas/src/shape/stroke_varwidth.rs (1)
204-207: Optimize path concatenation to avoid repeated builder reconstructions in the segment loop.Each iteration rebuilds a new
PathBuilder(new_path+add_path+detach) when concatenating segment paths. For loops with many segments, consider creating the builder once on the second segment and appending all remaining paths before a single finaldetach()to avoid repeated path structure copying.The suggested diff (keeping the first segment as
Path, then building once) is a reasonable minimal-churn approach. If feasible, a persistent builder across all iterations would eliminate repeated reconstructions entirely.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (36)
crates/grida-canvas/Cargo.toml(1 hunks)crates/grida-canvas/examples/golden_boolop.rs(3 hunks)crates/grida-canvas/examples/golden_path_discrete.rs(1 hunks)crates/grida-canvas/examples/golden_sk_mask.rs(3 hunks)crates/grida-canvas/examples/golden_sk_paints.rs(1 hunks)crates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs(3 hunks)crates/grida-canvas/examples/golden_sk_svg_filters/main.rs(1 hunks)crates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rs(3 hunks)crates/grida-canvas/src/devtools/hit_overlay.rs(1 hunks)crates/grida-canvas/src/devtools/ruler_overlay.rs(3 hunks)crates/grida-canvas/src/devtools/stroke_overlay.rs(1 hunks)crates/grida-canvas/src/devtools/text_overlay.rs(2 hunks)crates/grida-canvas/src/hittest/hit_tester.rs(3 hunks)crates/grida-canvas/src/painter/geometry.rs(3 hunks)crates/grida-canvas/src/painter/layer.rs(2 hunks)crates/grida-canvas/src/painter/painter.rs(4 hunks)crates/grida-canvas/src/painter/text_stroke.rs(2 hunks)crates/grida-canvas/src/shape/ellipse.rs(1 hunks)crates/grida-canvas/src/shape/ellipse_ring.rs(2 hunks)crates/grida-canvas/src/shape/ellipse_ring_sector.rs(10 hunks)crates/grida-canvas/src/shape/ellipse_sector.rs(3 hunks)crates/grida-canvas/src/shape/polygon.rs(1 hunks)crates/grida-canvas/src/shape/rect.rs(1 hunks)crates/grida-canvas/src/shape/rrect.rs(1 hunks)crates/grida-canvas/src/shape/srrect_orthogonal.rs(6 hunks)crates/grida-canvas/src/shape/stroke_rect.rs(4 hunks)crates/grida-canvas/src/shape/stroke_varwidth.rs(5 hunks)crates/grida-canvas/src/sk_tiny/mod.rs(1 hunks)crates/grida-canvas/src/svg/from_usvg_tree.rs(1 hunks)crates/grida-canvas/src/text/mod.rs(2 hunks)crates/grida-canvas/src/vectornetwork/vn.rs(6 hunks)crates/grida-canvas/src/window/application.rs(1 hunks)crates/grida-canvas/tests/dashed_stroke.rs(1 hunks)crates/grida-canvas/tests/open_path_stroke_align.rs(1 hunks)crates/grida-canvas/tests/stroke_dash_width.rs(1 hunks)crates/grida-dev/Cargo.toml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Use Rust 2024 edition for WASM builds and graphics core
Files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-canvas/src/devtools/text_overlay.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/shape/polygon.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/rrect.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/examples/golden_path_discrete.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/src/svg/from_usvg_tree.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/shape/stroke_rect.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/src/shape/ellipse.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/src/shape/stroke_varwidth.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rscrates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs
crates/grida-canvas/**/*.rs
📄 CodeRabbit inference engine (crates/grida-canvas/AGENTS.md)
crates/grida-canvas/**/*.rs: All internal structs (NodeRecs, SceneGraph, caches) must useNodeId(u64) for high-performance counter-based IDs in the rendering engine
Public APIs must accept and returnUserNodeId(String) instead ofNodeIdfor stability and serialization
UseIdConverterto handle conversion betweenNodeIdandUserNodeIdduring .grida file loading
NodeRepository must auto-generate IDs for factory-created nodes, assigning ID=0 as the default
Useskia-safecrate for all painting and rendering operations
Usemath2crate for all geometry and common math operations
Files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-canvas/src/devtools/text_overlay.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/shape/polygon.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/rrect.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/examples/golden_path_discrete.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/src/svg/from_usvg_tree.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/shape/stroke_rect.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/src/shape/ellipse.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/src/shape/stroke_varwidth.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rscrates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs
🧠 Learnings (24)
📓 Common learnings
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : Use `skia-safe` crate for all painting and rendering operations
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/*.rs : Run all tests with: `cargo test`
Learnt from: CR
Repo: gridaco/grida PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-01T00:21:48.564Z
Learning: Use Skia as the graphics backend for 2D graphics bound with skia-safe
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : Use `skia-safe` crate for all painting and rendering operations
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-dev/Cargo.tomlcrates/grida-canvas/src/devtools/text_overlay.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/shape/polygon.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/rrect.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/examples/golden_path_discrete.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/src/svg/from_usvg_tree.rscrates/grida-canvas/Cargo.tomlcrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/shape/stroke_rect.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/src/shape/ellipse.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/src/shape/stroke_varwidth.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rscrates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : Use `math2` crate for all geometry and common math operations
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-dev/Cargo.tomlcrates/grida-canvas/src/devtools/text_overlay.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/shape/polygon.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/rrect.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/examples/golden_path_discrete.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/Cargo.tomlcrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/shape/stroke_rect.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/src/shape/ellipse.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/src/shape/stroke_varwidth.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : Public APIs must accept and return `UserNodeId` (String) instead of `NodeId` for stability and serialization
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-dev/Cargo.tomlcrates/grida-canvas/src/devtools/text_overlay.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/shape/polygon.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/src/svg/from_usvg_tree.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/src/shape/stroke_varwidth.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/ui_parser_test.rs : High-level UI API tests should use `parse_ui` and be organized in `ui_parser_test.rs`
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/text/mod.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : All internal structs (NodeRecs, SceneGraph, caches) must use `NodeId` (u64) for high-performance counter-based IDs in the rendering engine
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/src/shape/stroke_rect.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/src/hittest/hit_tester.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/*.rs : Run all tests with: `cargo test`
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-dev/Cargo.tomlcrates/grida-canvas/Cargo.tomlcrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : Use `IdConverter` to handle conversion between `NodeId` and `UserNodeId` during .grida file loading
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/shape/ellipse_ring_sector.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rs
📚 Learning: 2025-12-01T00:22:19.083Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-wasm/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:19.083Z
Learning: Applies to crates/grida-canvas-wasm/**/main.rs : Update `grida-canvas-wasm.d.ts` TypeScript definitions file when new APIs are introduced via `main.rs`
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/shape/ellipse_ring.rscrates/grida-dev/Cargo.tomlcrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/shape/rect.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/Cargo.tomlcrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/src/shape/ellipse.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/src/window/application.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/src/painter/layer.rscrates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:56.899Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: editor/app/(tools)/tools/halftone/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:56.899Z
Learning: Applies to editor/app/(tools)/tools/halftone/app/(tools)/tools/halftone/_page.tsx : Use Canvas 2D API with path commands for rendering geometric shapes (circle, square, triangle, etc.)
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/painter/geometry.rscrates/grida-canvas/src/devtools/hit_overlay.rscrates/grida-canvas/src/shape/srrect_orthogonal.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/src/vectornetwork/vn.rscrates/grida-canvas/src/devtools/stroke_overlay.rscrates/grida-canvas/src/painter/painter.rscrates/grida-canvas/tests/dashed_stroke.rscrates/grida-canvas/examples/golden_sk_paints.rscrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/painter/text_stroke.rscrates/grida-canvas/examples/golden_sk_mask.rscrates/grida-canvas/src/shape/ellipse_sector.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rs
📚 Learning: 2025-12-01T00:22:28.164Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:28.164Z
Learning: Applies to crates/grida-canvas/**/*.rs : NodeRepository must auto-generate IDs for factory-created nodes, assigning ID=0 as the default
Applied to files:
crates/grida-canvas/tests/stroke_dash_width.rscrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/tests/dashed_stroke.rs
📚 Learning: 2025-12-01T00:22:36.510Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-dev/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:36.510Z
Learning: Applies to crates/grida-dev/grida-dev/Cargo.toml : The `grida-dev` crate is marked `publish = false` and is intended solely for local development workflows and devtools
Applied to files:
crates/grida-dev/Cargo.tomlcrates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/Cargo.toml : Use `ttf-parser = "0.25"` as the required dependency for font parsing backend
Applied to files:
crates/grida-dev/Cargo.tomlcrates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/Cargo.toml : Include dev-dependency `serde_json = "1.0"` for JSON testing
Applied to files:
crates/grida-dev/Cargo.tomlcrates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/Cargo.toml : Include optional `serde = "1.0"` with `derive` feature for JSON serialization support
Applied to files:
crates/grida-dev/Cargo.tomlcrates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:36.510Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-dev/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:36.510Z
Learning: The `cg` crate must remain platform-agnostic; all winit/glutin integration code must live in the `grida-dev` crate
Applied to files:
crates/grida-dev/Cargo.toml
📚 Learning: 2025-12-01T00:21:48.564Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-01T00:21:48.564Z
Learning: Applies to crates/**/*.rs : Use Rust 2024 edition for WASM builds and graphics core
Applied to files:
crates/grida-dev/Cargo.tomlcrates/grida-canvas/src/devtools/ruler_overlay.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rs
📚 Learning: 2025-12-01T00:22:56.899Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: editor/app/(tools)/tools/halftone/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:56.899Z
Learning: Applies to editor/app/(tools)/tools/halftone/app/(tools)/tools/halftone/_page.tsx : For SVG export, convert circles to <circle> elements, rectangles to <rect> elements, and polygons to <polygon> elements with calculated points
Applied to files:
crates/grida-canvas/src/devtools/stroke_overlay.rs
📚 Learning: 2025-12-01T00:21:48.564Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-01T00:21:48.564Z
Learning: Use Skia as the graphics backend for 2D graphics bound with skia-safe
Applied to files:
crates/grida-canvas/src/painter/painter.rscrates/grida-canvas/Cargo.tomlcrates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rscrates/grida-canvas/src/sk_tiny/mod.rscrates/grida-canvas/examples/golden_boolop.rscrates/grida-canvas/examples/golden_sk_svg_filters/main.rscrates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs
📚 Learning: 2025-12-01T00:22:19.083Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-wasm/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:19.083Z
Learning: Applies to crates/grida-canvas-wasm/**/+(grida-canvas-wasm.js|grida-canvas-wasm.wasm) : Include WASM artifacts (`grida-canvas-wasm.js` and `grida-canvas-wasm.wasm`) in git for faster CI builds
Applied to files:
crates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:19.083Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-wasm/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:19.083Z
Learning: Applies to crates/grida-canvas-wasm/**/Cargo.toml : Use the target `wasm32-unknown-emscripten` when building Rust code for WebAssembly compilation
Applied to files:
crates/grida-canvas/Cargo.toml
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/scenario_*.rs : Scenario-specific comprehensive tests should be organized in files matching `scenario_*.rs`
Applied to files:
crates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/serde_test.rs : Run tests with serde feature using: `cargo test --features serde`
Applied to files:
crates/grida-canvas/tests/open_path_stroke_align.rs
📚 Learning: 2025-12-01T00:22:06.800Z
Learnt from: CR
Repo: gridaco/grida PR: 0
File: crates/grida-canvas-fonts/AGENTS.md:0-0
Timestamp: 2025-12-01T00:22:06.800Z
Learning: Applies to crates/grida-canvas-fonts/**/italic_level1.rs : Core font selection and italic detection tests should be organized in `italic_level1.rs`
Applied to files:
crates/grida-canvas/tests/open_path_stroke_align.rs
🧬 Code graph analysis (11)
crates/grida-canvas/src/painter/geometry.rs (1)
crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)
crates/grida-canvas/src/devtools/hit_overlay.rs (3)
third_party/usvg/src/tree/text.rs (1)
path(436-438)crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)crates/grida-canvas/src/painter/layer.rs (2)
transform(101-101)transform(122-128)
crates/grida-canvas/src/shape/rrect.rs (2)
crates/grida-canvas/src/shape/stroke_rect.rs (1)
build_rrect(7-17)crates/grida-canvas/src/painter/layer.rs (2)
shape(102-102)shape(130-136)
crates/grida-canvas/src/devtools/stroke_overlay.rs (1)
crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)
crates/grida-canvas/src/painter/painter.rs (1)
crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)
crates/grida-canvas/examples/golden_sk_paints.rs (1)
crates/grida-canvas/src/node/schema.rs (9)
rect(867-867)rect(929-936)rect(1109-1116)rect(1266-1273)rect(1398-1405)rect(1606-1623)rect(1686-1688)rect(1800-1807)rect(1923-1930)
crates/grida-canvas/src/sk_tiny/mod.rs (1)
third_party/usvg/src/tree/text.rs (1)
path(436-438)
crates/grida-canvas/src/window/application.rs (2)
crates/math2/src/transform.rs (1)
translate(168-171)crates/grida-canvas/src/runtime/camera.rs (1)
translate(112-116)
crates/grida-canvas/examples/golden_boolop.rs (1)
.ref/canvaskit/canvaskit.d.ts (1)
PathOp(5010-5010)
crates/grida-canvas/src/hittest/hit_tester.rs (3)
third_party/usvg/src/tree/text.rs (1)
path(436-438)crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)crates/grida-canvas/src/painter/layer.rs (2)
transform(101-101)transform(122-128)
crates/grida-canvas/src/painter/layer.rs (2)
third_party/usvg/src/tree/text.rs (1)
path(436-438)crates/grida-canvas/src/sk/mod.rs (1)
sk_matrix(3-6)
🔇 Additional comments (39)
crates/grida-canvas/examples/golden_sk_svg_filters/main.rs (1)
1975-1996: LGTM! Clean migration to PathBuilder pattern.The refactor correctly adopts the PathBuilder pattern for skia-safe 0.91.0. The implementation properly:
- Initializes the builder
- Maps all TinyPath segments to corresponding builder methods
- Finalizes with
detach()to produce the immutable PathThis aligns with the PR objectives to update path building practices.
Based on learnings, the
skia-safecrate is used for all painting and rendering operations in this codebase.crates/grida-canvas/examples/golden_sk_mask.rs (4)
3-4: LGTM! Import changes support PathBuilder migration.The imports correctly add
PathBuilderfor the new path construction pattern and maintainTileModefor the gradient shaders.
41-48: Excellent PathBuilder pattern usage.The diagonal band path construction correctly adopts the PathBuilder pattern: creating a builder, chaining operations, closing, and detaching to obtain an immutable Path. This is the idiomatic approach for skia-safe 0.91.0.
54-58: Clean circular path construction.Using
Path::circleis the idiomatic way to create circular paths in skia-safe 0.91.0, eliminating the need for manual path building for simple geometric shapes.
69-73: Consistent circular path construction for outline.The outline path correctly uses the same
Path::circlepattern and geometry as the clip path, ensuring visual consistency between the clipped region and its outline.crates/grida-canvas/examples/golden_sk_paints.rs (1)
368-376: No action needed—code is correct as-is.
Path::rect(rect, None)is the idiomatic pattern throughout the codebase (used consistently in geometry.rs, shape/rect.rs, and other examples). The recent commit "update examples path building" confirms this is an intentional alignment with production code. No behavior drift or winding/direction concerns exist.crates/grida-canvas/src/shape/rrect.rs (1)
38-40: LGTM! Simplified path construction aligns with the migration pattern.The direct use of
Path::rrect()is more concise and idiomatic than the previous mutable approach. The API is supported in skia-safe 0.91.0 with the signaturepub fn rrect(rect: impl AsRef<RRect>, dir: impl Into<Option<PathDirection>>) -> Self, and your usage withNonefor the optional direction parameter is correct.crates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs (1)
501-525: No API correctness issues found — this code correctly implements the expected skia-safe 0.91.0 semantics.The
Paragraph::visitcallback signatureFnMut(usize, Option<&'a VisitorInfo>)matches the usage in the code (|_, run|). TheNoneparameter inadd_path_with_transformmeans "no additional transform" (identity), which is correct—the offset positioning is already applied viaMatrix::translatebefore theNoneis passed, so no winding or path behavior is affected. The implementation is idiomatic and sound.Likely an incorrect or invalid review comment.
crates/grida-canvas/src/shape/polygon.rs (1)
15-18: No changes required.build_path_from_pointsrelies onPath::polygon, which safely handles all point counts (0, 1, 2, and 3+ points) without panicking or exhibiting undefined behavior. All in-tree callers already enforce the n >= 3 precondition through assertions inbuild_simple_polygon_pathandbuild_simple_polygon_vector_network. No external callers exist in the codebase, eliminating the theoretical risk of unvalidated input from public consumers.crates/grida-canvas/src/devtools/ruler_overlay.rs (3)
3-3: LGTM! PathBuilder import added for 0.91.0 migration.The import correctly adds
PathBuilderto support the new path construction pattern.
94-94: Correct path finalization.Using
builder.detach()correctly finalizes the PathBuilder and produces the immutablePathfor caching and rendering.
67-89: PathBuilder pattern correctly applied.The migration from direct Path construction to PathBuilder follows the correct pattern: create builder, accumulate path operations via
move_to/line_to, then finalize withdetach(). The logic for constructing vertical and horizontal grid lines is preserved.Since this is a major version upgrade (0.89.0 → 0.91.0), verify that the PathBuilder API usage aligns with the skia-safe 0.91.0 documentation:
skia-safe 0.91.0 PathBuilder API documentationcrates/grida-canvas/src/painter/layer.rs (1)
1073-1076: The original concern aboutPath::make_transformreturningOption<Path>in skia-safe 0.91.0 is unfounded. The method signature ispub fn make_transform(&mut self, m: &Matrix, pc: impl Into<Option<ApplyPerspectiveClip>>) -> Path, returning an ownedPathvalue directly. The code at lines 1075 and 1092 correctly assigns the return value without optional handling. No changes needed.crates/grida-canvas/src/shape/ellipse_sector.rs (1)
1-48: PathBuilder migration is correct;arc_tosignature verified.The
arc_to(oval, start_angle, sweep_angle, force_move_to)call is properly implemented:
outer_rectcorrectly bounds the ellipsestart_degandsweep_deguse standard Skia angles (0° = +X axis, positive = clockwise)force_move_to=falseis the right choice since the path is non-empty (aftermove_toandline_toto the start point); this appends a line connecting the current point to the arc start, which is the intended behavior for a sectorNo changes needed.
crates/grida-canvas/examples/golden_path_discrete.rs (1)
5-5: Good simplification;Path::circle(..., None)correctly uses the default winding direction.The third parameter accepts
PathDirection(CW or CCW) to control the circle's winding direction. PassingNoneapplies the default behavior, preserving the expected semantics from any prior implementation.crates/grida-canvas/src/shape/ellipse.rs (1)
8-13: None for the direction parameter is correct and uses Skia's default clockwise direction.In skia-safe 0.91.0,
Path::oval(rect, dir)accepts an optionalPathDirectionas the second argument. PassingNonemeans the underlying Skia default (kCW / clockwise) is used. This preserves correct ellipse geometry and is an appropriate simplification.crates/grida-canvas/src/shape/rect.rs (1)
18-20:Path::rect(&rect, None)is correct for this conversion trait. It constructs a new Path from the rectangle using the appropriate defaults (clockwise direction, starting at upper-left). Since the trait implementation needs to return a new Path rather than mutate an existing one,Path::rect()(constructor) is the right choice, notadd_rect()(appender).crates/grida-canvas/src/devtools/text_overlay.rs (1)
32-41: PathBuilder baseline construction looks correctBuilder-based baseline segments should behave the same as the previous Path mutation pattern, and returning
Some(builder.detach())is consistent with the rest of the migration.crates/grida-canvas/src/devtools/hit_overlay.rs (1)
88-90: Transform order preserved; confirmmake_transformfailure semanticsThe sequential reassignment matches the old “apply layer, then apply camera” order. Only concern is whether
make_transformcan fail/produce empty paths in cases where the oldtransformmutated in-place—worth confirming via build + a quick devtools smoke test.crates/grida-canvas/src/sk_tiny/mod.rs (1)
8-30: TinyPath → SkPath conversion via PathBuilder looks correctThe segment mapping is direct and should preserve contour boundaries and closes.
crates/grida-canvas/src/painter/geometry.rs (1)
121-134: LGTM on direct constructors; double-checkNode::Lineintent + Skia API signatures
to_path()simplification reads clean and should reduce unnecessary path mutation.Path::line((0,0),(width,0))is fine if “Line” is defined as a horizontal segment in local space (with transforms handling rotation); just confirm thatn.size.heightis not meant to participate here.Also applies to: 163-164, 334-335
crates/grida-canvas/examples/golden_boolop.rs (3)
1-1: Import addition is fine; keep skia-safe path construction consistent across examples.This aligns with the broader PathBuilder migration (and matches the “use skia-safe for rendering” guideline). As per coding guidelines, use
skia-safefor painting/rendering operations.
15-16: Constructor-basedPath::rect/Path::circleusage looks correct.Nice simplification vs mutable path building; should reduce accidental mutation and match skia-safe 0.91+ patterns.
Also applies to: 27-28, 50-51, 59-60
36-42: Removeunwrap()onPath::opat line 61; the method can legitimately returnNone.Line 61 uses
.unwrap()on aPath::opcall that can fail. Since this is an example/test file that runs in CI, it should handle the failure gracefully rather than panic:- let union = Path::op(&r, &c, PathOp::Union).unwrap(); + let Some(union) = Path::op(&r, &c, PathOp::Union) else { + return; + };All other
Path::opcalls in this file (lines 17, 29, 43, 52, 68) are already correctly usingif let Some(...)pattern matching.Likely an incorrect or invalid review comment.
crates/grida-canvas/src/shape/stroke_rect.rs (1)
3-4: Import update is fine for the PathBuilder migration.crates/grida-canvas/src/painter/painter.rs (2)
16-19: Import extension for PathBuilder is fine.
976-982: Layer transform viamake_transformis the right direction (immutable transform).Looks consistent with the broader migration away from in-place mutation.
crates/grida-canvas/src/vectornetwork/vn.rs (3)
271-315: Builder-based segment-to-path conversion looks correct.Returning
builder.detach()for empty segments is a clean way to produce an emptyPath.
362-409: Region path construction +set_fill_typebeforedetach()is good.Optional hardening: if loops are supposed to always close, consider a final
builder.close()when a loop finishes but didn’t return to its start (to avoid surprising fill artifacts from malformed data).
417-423: Appending paths via a single builder is clean and consistent with the migration.crates/grida-canvas/src/text/mod.rs (3)
5-5: LGTM: Updated imports for PathBuilder migration.The imports correctly add
MatrixandPathBuilderto support the new path construction pattern.
34-37: LGTM: Clean API addition for vector network conversion.The new
paragraph_to_vector_networkfunction provides a convenient public API for converting paragraphs directly to vector networks. The implementation correctly delegates toparagraph_to_pathand leverages the existingVectorNetwork::fromconversion.
8-31: LGTM: PathBuilder migration is clean and includes zero-offset optimization.The refactored path construction correctly uses the builder pattern and adds an optimization to skip identity transforms when the glyph offset is zero. The conditional transform logic (lines 19-25) is a good performance enhancement. All APIs (PathBuilder, add_path, make_transform, detach) are properly available in skia-safe 0.91.0 and are correctly applied here.
crates/grida-canvas/tests/stroke_dash_width.rs (1)
5-18: LGTM: Test helper functions updated to PathBuilder pattern.Both helper functions correctly adopt the PathBuilder pattern for path construction. The changes are mechanical and preserve the original test behavior.
crates/grida-canvas/src/hittest/hit_tester.rs (1)
91-91: LGTM: Transform operations updated to immutable pattern.The change from
path.transform()topath = path.make_transform()adopts an immutable transformation approach, which is safer and aligns with the PathBuilder migration. Since the path is already cloned before transformation (lines 87, 117, 138), this change doesn't introduce additional overhead.Also applies to: 121-121, 142-142
crates/grida-canvas/tests/dashed_stroke.rs (1)
7-10: LGTM: Test updated to PathBuilder pattern.The test correctly adopts the PathBuilder pattern for path construction, maintaining the original test logic and assertions.
crates/grida-canvas/tests/open_path_stroke_align.rs (1)
7-10: LGTM: Test migrated to PathBuilder pattern.The path construction correctly uses PathBuilder, preserving the test's original behavior and assertions for stroke alignment on open paths.
crates/grida-canvas/examples/golden_sk_text_backdrop_blur_path.rs (1)
19-25: PathBuilder import aligns with the migration (but double-check 0.91.0 API surface).
Looks consistent with the newparagraph_to_pathimplementation. Since this relies onskia-safe0.91.0 API changes, please confirm the exact signatures you’re targeting (especially aroundPathBuildermethods).crates/grida-canvas/src/shape/stroke_varwidth.rs (1)
3-3: Import is correct for skia-safe 0.91.0.The
use skia_safe::{Path, PathBuilder};import is properly exposed in skia-safe 0.91.0, and the feature flags in Cargo.toml ("gpu", "gl", "textlayout", "pdf", "svg", "webp") do not restrict Path/PathBuilder availability. All methods used in the file—PathBuilder::new_path(),add_path(),detach(),move_to(), andclose()—are valid 0.91.0 APIs.
| [dependencies] | ||
| # skia | ||
| skia-safe = { version = "0.89.0", features = ["gpu", "gl", "textlayout", "pdf", "svg", "webp"] } | ||
| skia-safe = { version = "0.91.0", features = ["gpu", "gl", "textlayout", "pdf", "svg", "webp"] } |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
skia-safe 0.91.0 release notes changelog
💡 Result:
Summary of skia-safe 0.91.0 release (changelog)
- Released: 08 Dec (tag v0.91.0). Aligns the Rust bindings to Skia milestone 143. (github.com)
- Notable items:
- CI publishing workflows changed to give finer control over generated prebuilt binaries; some binary combinations were removed. (github.com)
- Path mutation functions were removed; use PathBuilder + snapshot() or detach() instead. (github.com)
- Fixes and small changes: broken Skottie README link, expose a custom_empty FontMgr, milestone 143 integration, and workflow simplification PRs. (github.com)
For the full changelog and individual PR links see the release entry on the rust-skia GitHub releases page. (github.com)
Citations:
- 1: https://github.com/rust-skia/rust-skia/releases
- 2: https://github.com/rust-skia/rust-skia/releases
- 3: https://github.com/rust-skia/rust-skia/releases
- 4: https://github.com/rust-skia/rust-skia/releases
- 5: https://github.com/rust-skia/rust-skia/releases
🌐 Web query:
skia-safe 0.91.0 Path make_transform rect oval circle API signatures
💡 Result:
Here are the Rust API signatures (skia-safe / rust-skia v0.91.0) you asked for:
-
Path::make_transform
- pub fn make_transform(&mut self, m: &Matrix, pc: impl Into<Option>) -> Path. [1][2]
-
Path::rect variants
- pub fn rect(rect: impl AsRef, dir: impl Into<Option>) -> Self.
- pub fn rect_with_fill_type(rect: impl AsRef, fill_type: PathFillType, dir: impl Into<Option>) -> Self. [1]
-
Path::oval variants
- pub fn oval(oval: impl AsRef, dir: impl Into<Option>) -> Self.
- pub fn oval_with_start_index(oval: impl AsRef, dir: PathDirection, start_index: usize) -> Self.
- pub fn add_oval(&mut self, oval: impl AsRef, dir_start: Option<(PathDirection, usize)>) -> &mut Self. [1][2]
-
Path::circle variants
- pub fn circle(center: impl Into, radius: scalar, dir: impl Into<Option>) -> Self.
- pub fn add_circle(&mut self, p: impl Into, radius: scalar, dir: impl Into<Option>) -> &mut Self. [1]
Sources: rust-skia docs. [1] rust-skia Path type and methods. [2] rust-skia path module (make_transform listed).
🏁 Script executed:
# Check the current Cargo.toml and edition setting
cat crates/grida-canvas/Cargo.toml | head -20Repository: gridaco/grida
Length of output: 420
🏁 Script executed:
# Search for usage of Path methods in the codebase
rg "Path::(make_transform|rect|oval|circle)" crates/grida-canvas/ -A 2 -B 2Repository: gridaco/grida
Length of output: 6349
🏁 Script executed:
# Check for any Rust 2024 edition requirements in the repo
rg "edition\s*=\s*\"2024\"" crates/ --type tomlRepository: gridaco/grida
Length of output: 102
🏁 Script executed:
# Search for mutable Path operations that may have been removed
rg "(add_rect|add_oval|add_circle|make_transform)" crates/grida-canvas/ -A 2 -B 2Repository: gridaco/grida
Length of output: 7862
🏁 Script executed:
# Search for any &mut Path usage patterns
rg "&mut.*Path" crates/grida-canvas/ -A 2 -B 2Repository: gridaco/grida
Length of output: 2711
🌐 Web query:
skia-safe 0.91.0 PathBuilder snapshot detach migration path mutation removal
💡 Result:
Short answer: In skia-safe 0.91.0 snapshot/detach are methods on Path (Path::snapshot(), Path::detach()) — not on PathBuilder — so migration is to finish building your path and call snapshot() / detach() on the Path you built (or use Path::raw / Path::new helpers). See the 0.91.0 docs showing Path::snapshot() and Path::detach(). [1][2]
If you have code that previously called snapshot/detach on a PathBuilder, change it to:
- obtain the built Path (e.g. let path = path_builder.finish(); or otherwise get the Path),
- then call path.snapshot() (returns a copy) or path.detach() (returns a copy and clears the original) as needed.
References:
- skia-safe Path documentation (shows snapshot & detach in 0.91.0). [1]
- skia-safe crate listing / 0.91.0 release docs. [2]
If you want, paste the snippet you need migrated and I’ll convert it.
Critical: skia-safe 0.91.0 removes Path::make_transform() – extensive codebase usage requires migration.
The upgrade to 0.91.0 introduces a breaking change: path mutation functions (including make_transform()) have been removed. The codebase has 15+ active uses of path.make_transform() across painter, text, hittest, and devtools modules that will fail to compile.
Migration: Instead of path.make_transform(&matrix), use PathBuilder to construct a new path with transformations applied, or build paths without mutation. Example pattern currently in ellipse_ring.rs shows the correct approach: use PathBuilder with add_oval() and detach().
Additionally, the package edition remains "2021" while repo guidelines recommend "2024" for graphics core—consider addressing in this PR or follow-up.
🤖 Prompt for AI Agents
crates/grida-canvas/Cargo.toml around line 11: skia-safe 0.91.0 removed
Path::make_transform(), breaking ~15 uses of path.make_transform() across
painter, text, hittest, and devtools; replace each mutate-in-place call with
code that constructs a new transformed Path via PathBuilder (or other
non-mutating API) — e.g., create a PathBuilder, add the original geometry (or
use the same builder pattern used in ellipse_ring.rs: add_oval()/other add_*
calls), apply the matrix transformation while building, then call detach() to
get the new Path; update all call sites accordingly to stop relying on path
mutation. Also consider updating the package edition from "2021" to "2024" in
this Cargo.toml either in this PR or in a follow-up per repo guidelines.
| use skia_safe::{ | ||
| self as sk, | ||
| font_style::{Slant, Weight, Width}, | ||
| path::AddPathMode, | ||
| surfaces, | ||
| textlayout::{ | ||
| FontCollection, Paragraph, ParagraphBuilder, ParagraphStyle, TextAlign, TextStyle, | ||
| TypefaceFontProvider, | ||
| }, | ||
| Color, Data, FontMgr, Path, Point, | ||
| Color, Data, FontMgr, Matrix, Path, PathBuilder, Point, | ||
| }; |
There was a problem hiding this comment.
Golden determinism + WASM parity risk: relies on system fonts (FontMgr::new() / “Arial”).
Since this file is used to generate a golden PNG, system-font selection can differ across machines/CI and diverge even more on WASM (per the PR note). Consider making all text (title/labels too) use fixture fonts (same TypefaceFontProvider/FontCollection approach you use elsewhere) so the output is deterministic. Based on learnings, skia-safe should be the backend, but the font source should be controlled.
🤖 Prompt for AI Agents
In crates/grida-canvas/examples/golden_sk_paragraph_path_vector.rs around lines
17 to 26, the example currently relies on system fonts (FontMgr::new()/“Arial”)
which breaks golden determinism and WASM parity; replace system font usage by
loading the fixture font(s) into a TypefaceFontProvider, attach that provider to
a FontCollection, and use that FontCollection for all Paragraph/ParagraphBuilder
TextStyles (title and labels included). Ensure you load the bundled font data
(e.g., via include_bytes! or the project fixture loader), register it with the
TypefaceFontProvider, set the default typeface in ParagraphStyle/TextStyle where
needed, and remove any calls to FontMgr::new() or hardcoded family names so the
generated PNG is deterministic across machines and WASM.
| path = path.make_transform(&sk::sk_matrix(transform.matrix)); | ||
| path = path.make_transform(&sk::sk_matrix(camera.view_matrix().matrix)); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, check the skia-safe version in the project
fd -e "Cargo.toml" | head -5 | xargs grep -l "skia-safe" | head -1 | xargs cat | grep -A 2 "skia-safe"Repository: gridaco/grida
Length of output: 39
🌐 Web query:
skia-safe 0.91.0 Path::make_transform return type documentation
💡 Result:
In skia-safe 0.91.0 the Path::make_transform signature is:
pub fn make_transform(&mut self, m: &Matrix, pc: impl Into<Option>) -> Path
It returns an owned Path (i.e., a new Path value). [1][2]
Sources:
[1] rust-skia docs — Path method list.
[2] rust-skia API page for Path.
🏁 Script executed:
# Search for make_transform usage in the codebase
rg "make_transform" --type rust -B 2 -A 2Repository: gridaco/grida
Length of output: 6937
Compose the two transform matrices into a single matrix, then apply one make_transform call to reduce path allocations.
The return type of make_transform is Path (not Option), so the code compiles. However, applying two sequential transforms creates two path allocations. Pre-compose transform.matrix with camera.view_matrix().matrix using AffineTransform::compose() (or equivalent matrix composition), then call make_transform once. This pattern is already used elsewhere in the codebase (e.g., painter/geometry.rs, painter/layer.rs).
- path = path.make_transform(&sk::sk_matrix(transform.matrix));
- path = path.make_transform(&sk::sk_matrix(camera.view_matrix().matrix));
+ let composed = camera.view_matrix().compose(&transform);
+ path = path.make_transform(&sk::sk_matrix(composed.matrix));Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In crates/grida-canvas/src/devtools/stroke_overlay.rs around lines 81-82, the
code applies two sequential make_transform calls which allocates two
intermediate Paths; instead, compose transform.matrix with
camera.view_matrix().matrix (e.g., via AffineTransform::compose() or equivalent
matrix multiplication) into a single AffineTransform, then call path =
path.make_transform(&sk::sk_matrix(composed.matrix)) once to apply both
transforms in one allocation.
| // Create path from centerline | ||
| let mut centerline_path = Path::new(); | ||
| centerline_path.add_rrect(centerline_rrect, None); | ||
| let mut centerline_builder = PathBuilder::new(); | ||
| centerline_builder.add_rrect(centerline_rrect, None, None); | ||
| let centerline_path = centerline_builder.detach(); | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n crates/grida-canvas/src/shape/stroke_rect.rs | head -50Repository: gridaco/grida
Length of output: 2188
🏁 Script executed:
cat -n crates/grida-canvas/src/shape/stroke_rect.rs | sed -n '1,30p'Repository: gridaco/grida
Length of output: 1337
🏁 Script executed:
cat -n crates/grida-canvas/src/shape/stroke_rect.rs | sed -n '315,360p'Repository: gridaco/grida
Length of output: 2040
Standardize PathBuilder qualification for consistency. PathBuilder is imported at line 3, but line 349 uses the fully qualified skia_safe::PathBuilder::new() while lines 321, 356, and 360 use the imported name directly. Use PathBuilder::new() everywhere to match the import style.
🤖 Prompt for AI Agents
In crates/grida-canvas/src/shape/stroke_rect.rs around lines 320-360, the file
imports PathBuilder but one occurrence uses the fully-qualified
skia_safe::PathBuilder::new() (line ~349) while other sites use
PathBuilder::new(); change that fully-qualified call to the imported
PathBuilder::new() so all usages consistently use the imported name.
| let mut builder = PathBuilder::new(); | ||
| add_catmull_segments(&mut builder, &left, false); | ||
| right.reverse(); | ||
| add_catmull_segments(&mut path, &right, true); | ||
| path.close(); | ||
| path | ||
| add_catmull_segments(&mut builder, &right, true); | ||
| builder.close(); | ||
| builder.detach() | ||
| } |
There was a problem hiding this comment.
Guard samples == 0 (division-by-zero) before building with PathBuilder.
for i in 0..=samples { let u = i as f32 / samples as f32; } will divide by zero when samples == 0. Since this is a pub fn, it should fail safe.
pub fn variable_width_stroke_geometry<FS, FT, FW>(
sample: FS,
tangent: FT,
width: FW,
samples: usize,
) -> Path
where
@@
{
+ if samples == 0 {
+ return Path::new();
+ }
// Arc-length LUT (denser than output samples for stability)
let (ts, us) = build_arc_lut(&sample, samples * 3);
@@
let mut builder = PathBuilder::new();
add_catmull_segments(&mut builder, &left, false);
right.reverse();
add_catmull_segments(&mut builder, &right, true);
builder.close();
builder.detach()
}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In crates/grida-canvas/src/shape/stroke_varwidth.rs around lines 280 to 286, the
code builds a PathBuilder after sampling, but the sampling loop uses `i as f32 /
samples as f32` which will panic on `samples == 0`; add a guard at the start of
the function (or immediately before building the path) to handle `samples == 0`
safely — either return an empty/degenerate Path (e.g., create and detach a new
PathBuilder without looping) or early-return a default Path value; ensure no
division by zero occurs by checking `if samples == 0 { /* return empty path */
}` before any loop that divides by `samples`.
| /// * `builder` - The PathBuilder to add segments to | ||
| /// * `pts` - Array of points to interpolate through | ||
| /// * `continue_path` - Whether to continue from the current path position or start a new subpath | ||
| fn add_catmull_segments(path: &mut Path, pts: &[(f32, f32)], continue_path: bool) { | ||
| fn add_catmull_segments(builder: &mut PathBuilder, pts: &[(f32, f32)], continue_path: bool) { | ||
| if pts.is_empty() { | ||
| return; | ||
| } | ||
| if !continue_path { | ||
| path.move_to(pts[0]); | ||
| builder.move_to(pts[0]); | ||
| } |
There was a problem hiding this comment.
continue_path=true likely needs an explicit join to pts[0] (otherwise first cubic starts from the wrong point).
When continuing, the current point is whatever the previous sub-path ended at, but the Catmull control math for the first segment is based on p1 = pts[0]. Without moving/connecting to pts[0], the first cubic_to will start at the wrong anchor and can distort the outline join.
Suggested fix:
fn add_catmull_segments(builder: &mut PathBuilder, pts: &[(f32, f32)], continue_path: bool) {
if pts.is_empty() {
return;
}
- if !continue_path {
- builder.move_to(pts[0]);
- }
+ if continue_path {
+ builder.line_to(pts[0]);
+ } else {
+ builder.move_to(pts[0]);
+ }
@@
- builder.cubic_to(c1, c2, p2);
+ builder.cubic_to(c1, c2, p2);
}
}Please verify PathBuilder::line_to exists in skia-safe 0.91.0 and that (f32, f32) tuples still coerce into the expected Skia point type for move_to/line_to/cubic_to.
skia-safe 0.91.0 PathBuilder move_to/line_to/cubic_to accepted argument types (Point vs tuples) and method signatures
Also applies to: 433-434
🤖 Prompt for AI Agents
In crates/grida-canvas/src/shape/stroke_varwidth.rs around lines 391-400 (and
similarly at 433-434), when continue_path is true you must explicitly join the
current point to pts[0] before emitting Catmull-Rom-derived cubics; add a call
to PathBuilder::line_to(pts[0]) (instead of move_to) when continue_path is true
so the first cubic starts from the correct anchor, and ensure you only call
move_to(pts[0]) when starting a new subpath; verify that skia-safe 0.91.0
exposes PathBuilder::line_to and that (f32, f32) tuples coerce to the Skia Point
type accepted by move_to/line_to/cubic_to before applying the change.
| if y_offset != 0.0 { | ||
| path.transform(&Matrix::translate((0.0, y_offset))); | ||
| path = path.make_transform(&Matrix::translate((0.0, y_offset))); | ||
| } | ||
| Some(VectorNetwork::from(&path)) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Find the file and examine the context around lines 358-361
head -n 370 crates/grida-canvas/src/window/application.rs | tail -n 25Repository: gridaco/grida
Length of output: 1044
🏁 Script executed:
# Search for y_offset definition and usage in the file
rg "y_offset" crates/grida-canvas/src/window/application.rs -B 5 -A 2Repository: gridaco/grida
Length of output: 875
🏁 Script executed:
# Check the broader context - find the paragraph_to_path function and how y_offset is derived
rg "paragraph_to_path|layout_height" crates/grida-canvas/src/window/application.rs -B 3 -A 3Repository: gridaco/grida
Length of output: 1005
🏁 Script executed:
# Find where n.height comes from and understand the Node structure
rg "struct.*Node|pub height" crates/grida-canvas/src --type rs -A 3 | head -50Repository: gridaco/grida
Length of output: 83
🏁 Script executed:
# Check if there's any validation on height values when nodes are created/loaded
rg "height.*is_finite|is_nan|is_infinite" crates/grida-canvas/src --type rsRepository: gridaco/grida
Length of output: 83
🏁 Script executed:
# Look at the paragraph module to understand height() return type and behavior
fd "paragraph" crates/grida-canvas/src --type fRepository: gridaco/grida
Length of output: 99
🏁 Script executed:
# Check skia-safe crate version and see if we can find usage patterns
rg "skia_safe.*Path|make_transform" crates/grida-canvas/src --type rs -A 1 -B 1 | head -40Repository: gridaco/grida
Length of output: 83
🏁 Script executed:
# Fix the rg commands - search for Node struct definition
rg "struct Node|pub height" crates/grida-canvas/src -A 3 | head -60Repository: gridaco/grida
Length of output: 3527
🏁 Script executed:
# Check paragraph.rs to understand height() behavior
cat crates/grida-canvas/src/cache/paragraph.rs | head -80Repository: gridaco/grida
Length of output: 3679
🏁 Script executed:
# Search for make_transform usage patterns
rg "make_transform" crates/grida-canvas/src -B 2 -A 2Repository: gridaco/grida
Length of output: 6427
🏁 Script executed:
# Search for Node struct definition to understand height field
rg "pub struct Node|^struct Node" crates/grida-canvas/src -A 20 | head -100Repository: gridaco/grida
Length of output: 6476
🏁 Script executed:
# Check if there's any validation when nodes are loaded/created
rg "\.height\s*=" crates/grida-canvas/src -B 3 -A 1 | head -60Repository: gridaco/grida
Length of output: 4257
🏁 Script executed:
# Look for any is_finite or validation patterns for floating point values
rg "is_finite|is_nan|is_normal|clamp" crates/grida-canvas/src | head -30Repository: gridaco/grida
Length of output: 3205
🏁 Script executed:
# Check paragraph.height() implementation
rg "fn height|pub fn height" crates/grida-canvas/src -A 3Repository: gridaco/grida
Length of output: 39
🏁 Script executed:
# Look at the specific context around the zoom_factor check to understand the pattern
rg "zoom_factor.is_finite" crates/grida-canvas/src/window/application.rs -B 5 -A 3Repository: gridaco/grida
Length of output: 488
🏁 Script executed:
# Check the image.rs pattern to see how is_finite is used for derived values
rg "scale.is_finite" crates/grida-canvas/src/painter/image.rs -B 5 -A 3Repository: gridaco/grida
Length of output: 284
🏁 Script executed:
# Search for where y_offset is computed to understand the full context
rg "let y_offset|y_offset\s*=" crates/grida-canvas/src/window/application.rs -B 10 -A 1Repository: gridaco/grida
Length of output: 594
Align y_offset guard with codebase defensive pattern
The code applies make_transform to y_offset, which is computed from user-provided n.height and layout-derived layout_height. Following the existing defensive pattern used for similar user-derived values (e.g., zoom_factor.is_finite() in the zoom path, sanitize_scale in image rendering), add a finiteness check:
- if y_offset != 0.0 {
- path = path.make_transform(&Matrix::translate((0.0, y_offset)));
- }
+ if y_offset.is_finite() && y_offset != 0.0 {
+ path = path.make_transform(&Matrix::translate((0.0, y_offset)));
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if y_offset != 0.0 { | |
| path.transform(&Matrix::translate((0.0, y_offset))); | |
| path = path.make_transform(&Matrix::translate((0.0, y_offset))); | |
| } | |
| Some(VectorNetwork::from(&path)) | |
| if y_offset.is_finite() && y_offset != 0.0 { | |
| path = path.make_transform(&Matrix::translate((0.0, y_offset))); | |
| } | |
| Some(VectorNetwork::from(&path)) |
🤖 Prompt for AI Agents
In crates/grida-canvas/src/window/application.rs around lines 358–361, the code
applies path.make_transform using y_offset derived from user inputs without
validating it; add a defensive finiteness check (e.g., if y_offset.is_finite())
so the transform is only applied when y_offset is finite (otherwise skip the
make_transform or treat as 0.0) to match the existing pattern used for
user-derived values.
1 participant
Investigate: texts wont render properly only on wasm target (rust-skia/rust-skia#1234)
need comprehensive render tests over text rendering and path building as 91+ introduces major changes.
Links:
Internal notes (AI researched, may contain false):
Summary by CodeRabbit
Chores
Refactor
New Features
✏️ Tip: You can customize this high-level summary in your review settings.