docs: document viewport culling investigation and findings#596
docs: document viewport culling investigation and findings#596softmarshmallow merged 2 commits intomainfrom
Conversation
Linear O(n) viewport culling was benchmarked against real-world SVG fixtures (up to 300K nodes). It regresses 8-13% on dense scenes where most nodes are visible. Updated optimization.md item 12 to note spatial index requirement. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo documentation files are added/updated to report investigation results for viewport culling optimization. A new investigation document details findings from benchmarking camera value caching and linear viewport culling, concluding that linear culling without spatial indexing regresses performance. An existing optimization guide is updated with a warning emphasizing that spatial indexing (R-tree) is required for viewport culling. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bd93bdd26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Per items 6, 12, and 36 in `optimization.md`: | ||
|
|
||
| - **Spatial index** (R-tree/quadtree, item 36) would make culling O(log n) instead of O(n) |
There was a problem hiding this comment.
The recommendation block points readers to the wrong follow-up work: in optimization.md, item 12 is Tight Bounds for save_layer Operations and item 36 is Scene Planner & Scheduler, while the spatial-index entry is item 38. Because this section is explicitly telling implementers what to pursue next, these misnumbered references will send follow-up work to unrelated optimizations instead of the intended spatial-index and SkPicture-caching sections.
Useful? React with 👍 / 👎.
1 participant
Linear O(n) viewport culling was benchmarked against real-world SVG fixtures (up to 300K nodes). It regresses 8-13% on dense scenes where most nodes are visible. Updated optimization.md item 12 to note spatial index requirement.
Summary by CodeRabbit