Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GridapDistributed to support Gridap v0.20 by replacing the previous Div/Curl-conforming FE space implementation with a new pullback/pushforward-based approach and adding corresponding regression tests.
Changes:
- Bump compatibility to
Gridap = "0.20.0"and package version to0.4.14. - Replace
DivAndCurlConformingFESpaces.jlwith newPullbacks.jlimplementation for globally consistent pushforwards/pullbacks (RT/Nédélec). - Add new Pullback tests and wire them into the sequential test runner; remove the old Div/Curl conforming sequential test.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Project.toml |
Bumps package version and updates Gridap compat to 0.20.0. |
src/GridapDistributed.jl |
Switches include from removed Div/Curl conforming implementation to Pullbacks.jl. |
src/Pullbacks.jl |
Adds new pullback/pushforward logic for distributed RT/Nédélec spaces. |
src/FESpaces.jl |
Refactors distributed FESpace constructors and GID generation; updates constraint handling to work with cell-wise reffes. |
src/DivAndCurlConformingFESpaces.jl |
Removed old implementation. |
test/PullbackTests.jl |
Adds regression tests validating global consistency of contributions across partitions. |
test/sequential/PullbackTests.jl |
Adds sequential wrapper for the new Pullback tests. |
test/sequential/runtests.jl |
Runs new Pullback tests in the sequential suite; removes old Div/Curl conforming sequential test reference. |
test/DivAndCurlConformingTests.jl |
Removed old test module. |
test/sequential/DivAndCurlConformingTests.jl |
Removed old sequential wrapper. |
test/HcurlProjectionTests.jl |
Formatting-only changes. |
test/sequential/FESpacesTests.jl |
Whitespace-only changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| reffe = map(cell_reffe) do cell_reffe | ||
| reffes, ctypes = compress_cell_data(cell_reffe) | ||
| return only(reffes) | ||
| end |> getany | ||
| _add_distributed_constraint(F,reffe,constraint) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 85.08% 84.68% -0.40%
==========================================
Files 16 16
Lines 4270 4237 -33
==========================================
- Hits 3633 3588 -45
- Misses 637 649 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.