Skip to content

Support for Gridap 0.20#200

Merged
JordiManyer merged 5 commits intomasterfrom
gridap-0.20
Mar 19, 2026
Merged

Support for Gridap 0.20#200
JordiManyer merged 5 commits intomasterfrom
gridap-0.20

Conversation

@JordiManyer
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GridapDistributed to support Gridap v0.20 by replacing the previous Div/Curl-conforming FE space implementation with a new pullback/pushforward-based approach and adding corresponding regression tests.

Changes:

  • Bump compatibility to Gridap = "0.20.0" and package version to 0.4.14.
  • Replace DivAndCurlConformingFESpaces.jl with new Pullbacks.jl implementation for globally consistent pushforwards/pullbacks (RT/Nédélec).
  • Add new Pullback tests and wire them into the sequential test runner; remove the old Div/Curl conforming sequential test.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Project.toml Bumps package version and updates Gridap compat to 0.20.0.
src/GridapDistributed.jl Switches include from removed Div/Curl conforming implementation to Pullbacks.jl.
src/Pullbacks.jl Adds new pullback/pushforward logic for distributed RT/Nédélec spaces.
src/FESpaces.jl Refactors distributed FESpace constructors and GID generation; updates constraint handling to work with cell-wise reffes.
src/DivAndCurlConformingFESpaces.jl Removed old implementation.
test/PullbackTests.jl Adds regression tests validating global consistency of contributions across partitions.
test/sequential/PullbackTests.jl Adds sequential wrapper for the new Pullback tests.
test/sequential/runtests.jl Runs new Pullback tests in the sequential suite; removes old Div/Curl conforming sequential test reference.
test/DivAndCurlConformingTests.jl Removed old test module.
test/sequential/DivAndCurlConformingTests.jl Removed old sequential wrapper.
test/HcurlProjectionTests.jl Formatting-only changes.
test/sequential/FESpacesTests.jl Whitespace-only changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +651 to +655
reffe = map(cell_reffe) do cell_reffe
reffes, ctypes = compress_cell_data(cell_reffe)
return only(reffes)
end |> getany
_add_distributed_constraint(F,reffe,constraint)
JordiManyer and others added 2 commits March 19, 2026 15:31
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 88.50575% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.68%. Comparing base (03499e6) to head (a08290d).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Pullbacks.jl 85.48% 9 Missing ⚠️
src/FESpaces.jl 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   85.08%   84.68%   -0.40%     
==========================================
  Files          16       16              
  Lines        4270     4237      -33     
==========================================
- Hits         3633     3588      -45     
- Misses        637      649      +12     
Flag Coverage Δ
mpi-adaptivity 45.99% <21.83%> (+0.70%) ⬆️
mpi-fespaces 40.31% <27.58%> (+0.47%) ⬆️
mpi-geometry 23.59% <21.83%> (+0.41%) ⬆️
mpi-misc 50.43% <88.50%> (+0.39%) ⬆️
mpi-physics 35.73% <86.20%> (-0.03%) ⬇️
mpi-transient 25.24% <21.83%> (+0.54%) ⬆️
seq-adaptivity 39.89% <21.83%> (+0.66%) ⬆️
seq-fespaces 42.02% <88.50%> (+1.75%) ⬆️
seq-geometry 23.63% <21.83%> (+0.41%) ⬆️
seq-misc 35.34% <82.75%> (+0.50%) ⬆️
seq-physics 35.72% <86.20%> (-1.06%) ⬇️
seq-transient 24.50% <21.83%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JordiManyer JordiManyer merged commit cbd7197 into master Mar 19, 2026
27 of 29 checks passed
@JordiManyer JordiManyer deleted the gridap-0.20 branch March 19, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants