Add some explanations for the strategy solving the Poisson problems with non-homogeneous Dirichlet boundary conditions#127
Add some explanations for the strategy solving the Poisson problems with non-homogeneous Dirichlet boundary conditions#127amartinhuertas merged 8 commits intogridap:masterfrom wei3li:master
Conversation
|
Hi @wei3li ! Thanks for your work. I will start now with my review. |
|
I have generated the page of the tutorial locally on my machine, and I noted that there are some typos, and line breaks missing in the result. This is in particular what I see: I guess that you modified and pushed the tutorial sources without double checking that the generated page looks as you were expecting, right? No problem. Indeed, I couldnt find the instructions on the README file nor in the documentation of the Tutorials repo in order to generate locally the HTML pages of the tutorials. To this end, you have to follow the following instructions once: and then, each time that you perform a change on the tutorial sources, you have to execute the following from the shell: to generate the HTML pages. The pages generated are available at "Tutorials/docs/build/pages". You can open them, e.g., with Google Chrome. Perhaps, once you are familiar with these instructions, we may add a section to the README file, something like "Generating tutorial HTML pages locally" or in the Wiki of the repo, https://github.com/gridap/Tutorials/wiki. As a first step in the review process, can you please modify the sources of the tutorial so that the generated page looks as you were expecting and push your changes? Thanks! On the other hand, with respect to the contents, while they are correct, they go may be too straight to the point. I think is better to add some more narrative and motivation about why we are doing this. I can do this part once you add your changes, ok? |
|
For the records, @wei3li was able to generate locally the ipynb files using Literate.jl, and they looked ok for the changes at hand. The issue seems to be in the generated HTML pages, not actually in the ipynb files. |
amartinhuertas
left a comment
There was a problem hiding this comment.
Hi @wei3li, I have finished my review. You can proceed with the requested changes. Thanks!
amartinhuertas
left a comment
There was a problem hiding this comment.
@wei3li ... thanks for your work! I just added a pair of additional comments. The tutorial is looking much better!
amartinhuertas
left a comment
There was a problem hiding this comment.
@wei3li ... I am satisfied with the current changes. I will accept the PR now. Thanks!
|
One more commit, I added the definition to |
Ok, I already noticed it. The changes are already available at the official tutorials repo. |

No description provided.