Skip to content

Conversation

@RubenGarcia
Copy link
Contributor

When using gtc and EUDAT B2STAGE, the users may not be connected to the unix users in the machine (e.g. if authorization uses OpenID tokens).
I added an option to allow modification of the gridmap file even if the unix user does not exist (-f -- force)

@fscheiner fscheiner self-requested a review August 20, 2020 13:19
@fscheiner
Copy link
Member

@matyasselmeci
Strange, the Travis-CI check didn't work or didn't finish since Aug 18th, 3:00 PM GMT+2. I also don't see it on Travis-CI. Can this check be retriggered somehow?

Copy link
Member

@fscheiner fscheiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenGarcia
Could you please make the change to https://github.com/gridcf/gct/pull/134/files#diff-970a287b14b8f63d7c4d1b1660881053, recreate the corresponding manpage and force-push your changes, so the PR gets updated?

I'd do it myself, but the GUI seems to not allow changes to your branch from me. Maybe because you create the PR from your master branch and not a "feature" branch.

@fscheiner
Copy link
Member

@RubenGarcia
It could also be due to that you unchecked the "Allow edits by maintainers" checkbox when creating this PR, that I am unable to update your changes. I think allowing such changes in future PRs could speed up their inclusion, so better keep this checkbox always checked.

@RubenGarcia
Copy link
Contributor Author

I can't find how to change the option, so I'll perform your changes.

@RubenGarcia RubenGarcia requested a review from fscheiner August 21, 2020 08:50
@fscheiner
Copy link
Member

I can't find how to change the option, so I'll perform your changes.

Indeed, I think this can only be activated when creating the PR.

Copy link
Member

@fscheiner fscheiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fscheiner fscheiner merged commit 2809d80 into gridcf:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants