Skip to content

Conversation

@ellert
Copy link
Member

@ellert ellert commented Mar 30, 2021

Compatibility with libnice 0.1.18

NiceCandidate has no sockptr member any more.

@maarten-litmaath
Copy link

Looks promising, thanks!

Copy link

@fr4nk5ch31n3r fr4nk5ch31n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for SUSE work again for openSUSE Tumbleweed (with libnice 0.1.18) and also still work for older distributions.

So let's merge this.

Copy link
Member

@fscheiner fscheiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with "correct" user:

Builds for SUSE work again for openSUSE Tumbleweed (with libnice 0.1.18) and also still work for older distributions.

So let's merge this.

@fscheiner fscheiner merged commit 3660ddc into gridcf:master Apr 1, 2021
@ellert ellert deleted the libnice-0.1.18 branch April 1, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants