Switch packaging from PyInstaller to Nuitka

[gridhead]

Switch packaging from PyInstaller to Nuitka

Assisted-by: Claude Opus 4.6 noreply@anthropic.com

Summary by Sourcery

Switch project packaging and CI workflows from PyInstaller to Nuitka for building distributable binaries.

Enhancements:

• Relax application teardown in the Qt front-end by safely handling TypeError when cleaning temporary files under the main window destructor.

Build:

• Update GNU/Linux and Windows GitHub Actions workflows to install and use Nuitka instead of PyInstaller, standardizing on Python 3.13 and adding required system build dependencies on Linux.
• Temporarily disable artifact upload steps in both GNU/Linux and Windows binary build workflows.

Chores:

• Replace PyInstaller with Nuitka in development dependencies and regenerate the uv.lock file accordingly.

[sourcery-ai]

Reviewer's Guide

Switches the build system from PyInstaller to Nuitka for both Linux and Windows GitHub Actions workflows, updates dev dependencies accordingly, adds manual workflow triggers, adjusts system/compiler prerequisites, and hardens a destructor against TypeError during temp-file cleanup.

Flow diagram for hardened temp file cleanup in destructor

flowchart TD
  A[WindMainWindow___del__] --> B[Call_kill_temp_file]
  B --> C{TypeError_raised?}
  C -->|No| D[Destructor_completes_normally]
  C -->|Yes| E[Catch_TypeError]
  E --> F[Ignore_error_and_continue]
  F --> D

Loading

File-Level Changes

Change	Details	Files
Migrate CI build workflows from PyInstaller to Nuitka for Linux and Windows, including runtime options and platform-specific flags.	Change Python setup to use a single 3.13 version instead of a version range. Replace installation of PyInstaller with Nuitka via pip while keeping uv. Add Linux build prerequisites installation step via dnf (patchelf, ccache, gcc, python-devel). Replace PyInstaller CLI calls with python -m nuitka including PySide6 plugin, onefile mode, output directory/filenames, and Windows-specific flags (no console, icon). Comment out artifact upload steps for both Linux and Windows workflows, effectively disabling artifact publishing for now. Add workflow_dispatch trigger to allow manual runs in addition to scheduled runs.	.github/workflows/gnul.yml .github/workflows/mswn.yml
Update development dependencies to use Nuitka instead of PyInstaller.	Replace PyInstaller dev dependency with a pinned Nuitka version range in the dev optional-dependencies group. Regenerate or update uv.lock to reflect dependency changes.	pyproject.toml uv.lock
Harden temporary file cleanup in the UI class destructor to avoid errors under Nuitka or different runtime conditions.	Wrap kill_temp_file() call in a try/except in the destructor to catch and ignore TypeError, preventing destructor-time crashes.	gi_loadouts/face/wind/main.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the Qt window destructor, catching TypeError and silently pass-ing risks hiding real bugs; consider either narrowing the condition (e.g., checking the state before calling kill_temp_file) or at least logging the exception so unexpected failures are visible.
• The GNU/Linux workflow now assumes a dnf-based environment for system dependencies; if this runs on standard GitHub-hosted Ubuntu runners, you may want to switch to apt or gate this step to avoid failures on non-Fedora images.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the Qt window destructor, catching `TypeError` and silently `pass`-ing risks hiding real bugs; consider either narrowing the condition (e.g., checking the state before calling `kill_temp_file`) or at least logging the exception so unexpected failures are visible.
- The GNU/Linux workflow now assumes a `dnf`-based environment for system dependencies; if this runs on standard GitHub-hosted Ubuntu runners, you may want to switch to `apt` or gate this step to avoid failures on non-Fedora images.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request replaces PyInstaller with Nuitka as a development dependency and updates the lock file. It also adds a try-except block to the del method in gi_loadouts/face/wind/main.py to handle TypeErrors during cleanup. Feedback suggests that using del for resource management is unreliable and recommends refactoring the cleanup logic to use the atexit module instead.

[gemini-code-assist]

Using __del__ for resource cleanup is generally discouraged as its execution is not guaranteed, especially during interpreter shutdown. This can lead to resource leaks.

A more robust approach is to use the atexit module to register cleanup functions. This ensures that kill_temp_file is called reliably when the program exits.

I recommend this refactoring:

1. Add import atexit at the top of gi_loadouts/face/wind/main.py.
2. In the MainWindow.__init__ method, add atexit.register(kill_temp_file).
3. Remove this __del__ method entirely.

This will make resource cleanup more predictable and robust.

[sdglitched]

LGTM 🚀

I need to know more about Nuitka before commenting on its usability. As the workflow was fine and the compiled object is running, I'll merge this.