Simplify the way we generate multiple values from datasets #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doughsay
commented
Jul 9, 2025
doughsay
commented
Jul 9, 2025
Comment on lines
+103
to
+105
| <.polyline points={points(@dataset1[:x], @dataset1[:y])} stroke="orange" stroke-width="2" /> | ||
| <.polyline points={points(@dataset2[:x], @dataset2[:y])} stroke="blue" stroke-width="2" /> | ||
| <.polyline points={points(@dataset3[:x], @dataset3[:y])} stroke="green" stroke-width="2" /> |
Contributor
Author
There was a problem hiding this comment.
Example of the value generator being used outside the library.
Comment on lines
+380
to
+386
| :for={{cx, cy, r, fill, stroke, stroke_width} <- values([@cx, @cy, @r, @fill, @stroke, assigns[:"stroke-width"]])} | ||
| cx={cx} | ||
| cy={cy} | ||
| r={r} | ||
| fill={fill} | ||
| stroke={stroke} | ||
| stroke-width={stroke_width} |
Contributor
Author
There was a problem hiding this comment.
Example of the value generator being used internal to the library
nkyllonen
reviewed
Jul 9, 2025
Comment on lines
+406
to
+408
| def points(x, y) do | ||
| values([x, y]) | ||
| end |
nkyllonen
reviewed
Jul 9, 2025
| |> Enum.uniq() | ||
|
|
||
| case datasets do | ||
| defp validate_zero_or_one_dataset(data) do |
Collaborator
There was a problem hiding this comment.
This is a little silly, but now that circle isn't using this directly, I would like to move this below values/1 since that is where it's being used.
nkyllonen
approved these changes
Jul 9, 2025
nkyllonen
pushed a commit
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for a "value generator" function (with simple helper
points). The idea is that many graphing components are going to need to generate values from datasets. Sometimes you want to do this internal to the library (see thecirclecomponent). Sometimes you want to let the user use the value generator directly (see the polyline example in the phoenix playground). I think this is simple and elegant. Thoughts?