Skip to content

fix resize not taking margin height into account #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Feb 27, 2020
Merged

fix resize not taking margin height into account #1169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gridstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,7 +1296,7 @@
// TODO: cellHeight = cellHeight() causes issue (i.e. remove strictCellHeight above) otherwise
// when sizing up we jump almost right away to next size instead of half way there. Not sure
// why as we don't use ceil() in many places but round() instead.
cellHeight = self.$el.height() / parseInt(self.$el.attr('data-gs-current-row'));
cellHeight = (self.$el.height() + grid.verticalMargin()) / parseInt(self.$el.attr('data-gs-current-row'));
Copy link
Member

@adumesny adumesny Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be self.verticalMargin() but I can change it later.

Copy link
Member

@adumesny adumesny Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this fixes the issue, one downside is that now you need to stretch WAY past 50% point to get next size up. So that needs to be looked at as well.

self.placeholder
.attr('data-gs-x', o.attr('data-gs-x'))
.attr('data-gs-y', o.attr('data-gs-y'))
Expand Down