Skip to content

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Mar 9, 2020

Description

EARLY WORK so other can contribute outside my personal branch - another BIG, BIG change

  • converted all code to Typescript classes (tons of JS code left to cleanup)
  • initial bundling with webpack to gridstack.all.js for browser inclusion
  • added index.ts to include all modules and dependencies for build
  • part-2 of gridstack Consider dropping JQuery / typescript conversion ? #1084

TODO:

  • modified just float.html to test new code. still not running (missing GridStack export in browser)
  • need to use tsc to output for typescript native files ?
  • none of the test are being checked yet, so ALL WILL FAIL.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

another BIG, BIG change
* converted all code to Typescript
* initial bundling with webpack to `gridstack.all.js` for browser inclusion
* added index.ts to include all modules and dependencies for build
* part-2 of gridstack #1084

TODO:
* modified float.html to test new code. still not running (missing `GridStack` export)
* need to use tsc to output for typescript native files ?
@adumesny adumesny merged commit 30a33f3 into gridstack:typescript Mar 9, 2020
@adumesny adumesny changed the title Typescript conversion TS: Typescript conversion Mar 10, 2020
@adumesny adumesny changed the title TS: Typescript conversion TS: Typescript conversion initial Mar 10, 2020
@adumesny adumesny changed the title TS: Typescript conversion initial TS: Typescript conversion Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant