TS: working demos #1212
Merged
TS: working demos #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed a bunch more jquery code in main file (more drag&drop will need to move out) * all the demos are finally running, found a bunch of issues of DOM vs jquery ->all but knockout which always inserts at (0,0) now -> RTL works a little better now, but still broken (hasn't worked in a while) * public API that take string | HTMLElement will now handle list with selector * using 'let' everywhere since not real global const TODO: fix lint and test cases next...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(more drag&drop will need to move out)
->all but knockout which always inserts at (0,0) now
-> RTL works a little better now, but still broken (hasn't worked in a while)
more Consider dropping JQuery / typescript conversion ? #1084
TODO: fix lint and test cases next...
Checklist
yarn test)