Skip to content

TS: tweaks to 'removed' callback #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Aug 17, 2020
Merged

TS: tweaks to 'removed' callback #1337

adumesny merged 1 commit into from
Aug 17, 2020

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Aug 17, 2020

Description

  • make sure we remove drag&drop handler
  • reset el.gridstackNode before callback to let callee know it's going away.
  • Only remove if not already done.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
TS: tweaks to 'removed' callback
bec56a9 
*make sure we remove drag&drop handler
* reset el.gridstackNode before callback to let callee know it's going away.
* Only remove if not already done.
@adumesny adumesny merged commit 2c42754 into gridstack:typescript Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adumesny