Skip to content

fix to getElements() methods #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Sep 21, 2020
Merged

fix to getElements() methods #1372

adumesny merged 1 commit into from
Sep 21, 2020

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Sep 21, 2020

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • [] Extended the README / documentation, if necessary

@adumesny
fix to getElements() methods
3e5071d 
* tweaks code made in gridstack#1365
* reverted back to supporting  multiple selectors, but now checking for '.' and '#' before adding them
* getGridElement() now re-uses getElement()
@adumesny adumesny merged commit cd0f1d3 into gridstack:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adumesny