h5: drag&drop code cleanup #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* went through new code for DD and made sure we have a type for everything * cleanup to match lib style (public vs private) * made all routines return 'this' for chainable calls. Abstract DDBaseImplement still return :void otherwise had to do `return this as unknown as DDBaseImplement` for all sub-classes which is annoying. * created DDUIData to hold what we need for callback data. Commented out part we don't use today...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
otherwise had to do
return this as unknown as DDBaseImplementfor all sub-classes which is annoying.