_is_one_column_mode unreliable within five pixels #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umn_mode to be incorrect. To test this, go to any gridstack and make the page width 769px. Single column mode via CSS will not kick in, yet elements will not be draggable.
Member
Author
|
This can be seen even on http://troolee.github.io/gridstack.js/ - make the page just over 768px (769, 770) and try to drag-and-drop the elements. I am testing this on Mac - Chrome, but I would guess it happens on most (all) browsers. |
Member
Author
|
Upon further testing, this appears to only happen with certain resolutions - including Thunderbolt display and another high-dpi 27" monitor. However, with the 15" resolutionary Macbook Pro, it does not happen. |
troolee
added a commit
that referenced
this pull request
May 30, 2015
_is_one_column_mode unreliable within five pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(window).width() is incorrect by about 5 pixels, causing _is_one_column_mode to be incorrect. To test this, go to any gridstack and make the page width 769px. Single column mode via CSS will not kick in, yet elements will not be draggable.