load() in 1 column mode layout fix #1488
Merged
+165
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fif for 1471 * when `load()` is called into a grid that is 1 column mode due to small area, we now cache the original 12 column layout to restore correctly * added sample code. Had to change more code than expected. * Also optimized loading to not re-do some items (re-writing attr multiple times) * Also fixed react sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for Resizing from a small screen to a larger screen doesn't set correct widget dimension when rescaled #1471
when
load()is called into a grid that is 1 column mode due tosmall area, we now cache the original 12 column layout to restore correctly
added sample code. Had to change more code than expected.
Also optimized loading to not re-do some items (re-writing attr multiple times)
Also fixed react sample
Checklist
yarn test)