new addGrid() method to create a grid + children #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new API to create a grid and it's children * load() will now recursively create nested grid * updated nested.html to use new API * fixed tests TODO: next have save() work on nested grids (API will have to change)
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Nov 30, 2020
* continue gridstack#1498 * addGrid() is now static as it can replace inti() method actually * fixed nested.html demo to use it instead of load() and fixed button actions. * noticed dragOut:false is no longer working (even in JQ case). Will post bug.
This was referenced Nov 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: next have save() work on nested grids (API will have to change)
Checklist
yarn test)