Skip to content

fix to disableMove() #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Jan 2, 2021
Merged

fix to disableMove() #1551

adumesny merged 1 commit into from
Jan 2, 2021

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Jan 2, 2021

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
fix to disableMove()
d53af5c 
* fix gridstack#1545
* make sure to remove event handlers when disabling move
* constructor now calls enable(), and destroy calls disable() to centralize call
@adumesny adumesny merged commit 471036c into gridstack:develop Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable / Disable Move does not really disable move :-)

1 participant

@adumesny