Skip to content

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Feb 20, 2021

Description

more fix for #1094 (part II of #1621)

  • we now check for >50% coverage (using pixel drag vs target region) before
    we collide during a drag to replace
  • this means we now support larger size swapping at their mid point.
    target is always used for mid point.

Note: web demo (#1094) is still not totally ideal as item 9 goes side way for some reason...

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

more fix for gridstack#1094 (part II of gridstack#1621)
* we now check for >50% coverage (using pixel drag vs target region) before
we collide during a drag to replace
* this means we now support larger size swapping at their mid point.
target is always used for mid point.

Note: web demo (gridstack#1094) is still not totally ideal as item 9 goes side way for some reason...
@adumesny adumesny merged commit 58a83af into gridstack:develop Feb 20, 2021
@adumesny
Copy link
Member Author

adumesny commented Feb 20, 2021

showing 50% coverage (sized 2 instead of 1 items)

20210219_225342.mp4

web demo (still some issues left, especially placing below)

20210219_225827.mp4

this stuff is HARD!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant