addWidget() while in 1 column fix
#1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* before we modify the passed in layout, we make a (shallow) copy so sort() doesn't affect user's data * also removed passing removeDOM to onChange() callback as we have node._removeDOM
* fix gridstack#1655 * `addWidget()` while in 1 column now remembers original wanted width (saves in 12 column layout) * removed uneeded _oneColumnMode (check for opts.column === 1) * updated responsive demo to add a 4x1 widget (test while in 1 column, size up back to 12 column)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addWidget()while in 1 column now remembers original wanted width(saves in 12 column layout)
(test while in 1 column, size up back to 12 column)
Checklist
yarn test)