Skip to content

Trigger change event for add/remove #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troolee merged 1 commit into from
Jul 22, 2015
Merged

Trigger change event for add/remove #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ to completely lock the widget.

### onchange(items)

Occurs when widgets change their position/size
Occurs when adding/removing widgets or existing widgets change their position/size

```javascript
var serialize_widget_map = function (items) {
Expand Down
25 changes: 19 additions & 6 deletions src/gridstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,21 @@
$(window).resize(on_resize_handler);
on_resize_handler();
};

GridStack.prototype._trigger_change_event = function(forceTrigger) {
var elements = this.grid.get_dirty_nodes();
var hasChanges = false;

var eventParams = [];
if (elements && elements.length) {
eventParams.push(elements);
hasChanges = true;
}

if (hasChanges || forceTrigger === true) {
this.container.trigger('change', eventParams);
}
};

GridStack.prototype._init_styles = function() {
if (this._styles_id) {
Expand Down Expand Up @@ -638,9 +653,7 @@
.attr('data-gs-height', node.height)
.removeAttr('style');
self._update_container_height();
var elements = self.grid.get_dirty_nodes();
if (elements && elements.length)
self.container.trigger('change', [elements]);
self._trigger_change_event();

self.grid.end_update();
};
Expand Down Expand Up @@ -704,6 +717,7 @@
this.container.append(el);
this._prepare_element(el);
this._update_container_height();
this._trigger_change_event(true);

return el;
};
Expand All @@ -722,6 +736,7 @@
this._update_container_height();
if (detach_node)
el.remove();
this._trigger_change_event(true);
};

GridStack.prototype.remove_all = function(detach_node) {
Expand Down Expand Up @@ -846,9 +861,7 @@
callback.call(this, el, node);

self._update_container_height();
var elements = self.grid.get_dirty_nodes();
if (elements && elements.length)
self.container.trigger('change', [elements]);
self._trigger_change_event();

self.grid.end_update();
};
Expand Down