Skip to content

dragging clipp fix part II #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Dec 23, 2021
Merged

dragging clipp fix part II #1904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/h5/dd-draggable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,20 @@ export class DDDraggable extends DDBaseImplement implements HTMLElementExtendOpt
/** @internal */
private _setupHelperStyle(): DDDraggable {
// TODO: set all at once with style.cssText += ... ? https://stackoverflow.com/questions/3968593
this.helper.style.pointerEvents = 'none';
this.helper.style.width = this.dragOffset.width + 'px';
this.helper.style.height = this.dragOffset.height + 'px';
this.helper.style.willChange = 'left, top';
this.helper.style.transition = 'none'; // show up instantly
this.helper.style.position = 'fixed'; // let us drag between grids by not clipping as parent .grid-stack is position: 'relative'
this.helper.style['min-width'] = 0; // since we no longer relative to our parent and we don't resize anyway (normally 100/#column %)
const rec = this.helper.getBoundingClientRect();
const style = this.helper.style;
style.pointerEvents = 'none';
style['min-width'] = 0; // since we no longer relative to our parent and we don't resize anyway (normally 100/#column %)
style.width = this.dragOffset.width + 'px';
style.height = this.dragOffset.height + 'px';
style.willChange = 'left, top';
style.position = 'fixed'; // let us drag between grids by not clipping as parent .grid-stack is position: 'relative'
style.left = rec.left + 'px';
style.top = rec.top + 'px';
style.transition = 'none'; // show up instantly
setTimeout(() => {
if (this.helper) {
this.helper.style.transition = null; // recover animation
style.transition = null; // recover animation
}
}, 0);
return this;
Expand Down