Skip to content

private --> protected #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Mar 1, 2022
Merged

private --> protected #1939

adumesny merged 1 commit into from
Mar 1, 2022

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Mar 1, 2022 •
edited
Loading

Description

  • changed private to protected so subclasses can access full implementation of base classes.
  • more cleanup on the engine (_notify() second param was removed as never used, Layout per column uses Node types instead), doc tweaks, etc...

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
private --> protected
d6a3d3e 
* changed private to protected so subclasses can access full implementation of base classes.
* more cleanup on the engine (_notify() second param was removed as never used, Layout per column uses Node types instead), doc tweaks, etc...
@adumesny adumesny merged commit 2d92b48 into gridstack:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adumesny