more mobile fixes: isTouch was true on Win10
#2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more mobile fixed for gridstack#1757 * turns out window.TouchEvent=true on windows 10 Chrome, so don't use it to detect `isTouch` as we were getting double enter/pointerEnter events * some fix to draggable (desktop tested) * placeholder is not a 10% black shadow (easier to see than dashed outline) TODO: in nested.html dragging to other and back to different spot goes to original not dropped location. Apparently the flow is very different from draggable for nested grids... need more work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
more mobile fixed for #1757
isTouchas we were getting double enter/pointerEnter eventsTODO: in nested.html dragging to other and back to different spot goes to original not dropped location.
Apparently the flow is very different from draggable for nested grids... need more work.
Checklist
yarn test)