update Grid's options when setting float #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhowell2-fleetio
force-pushed
the
fix-float-save-options
branch
from
f29a2f4 to
1a8d542
Compare
adumesny
reviewed
Aug 24, 2022
src/gridstack.ts
Outdated
| delete o.alwaysShowResizeHandle; | ||
| } | ||
| Utils.removeInternalAndSame(o, GridDefaults); | ||
| o.float = this.engine.float |
Member
There was a problem hiding this comment.
no I would do it on float(true) API to set them both instead. user might never call save.
Contributor
Author
There was a problem hiding this comment.
@adumesny changed. I also checked if the value actually changed so that _triggerChangeEvents wasn't called when nothing changed, but I can see this maybe being undesired too. Lemme know.
bhowell2-fleetio
force-pushed
the
fix-float-save-options
branch
from
1a8d542 to
4961acd
Compare
Member
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync the Grid's options with the float value.
I also set to check if the value actually changed before calling
triggerChangeEvent, but maybe this is not desired?