Skip to content

Vuejs error making GS freeze #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Dec 30, 2022
Merged

Vuejs error making GS freeze #2141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ <h1>Demos</h1>
<li><a href="two_vertical.html">Two grids Vertical</a></li>
<li><a href="vue2js.html">Vue2.js</a></li>
<li><a href="vue3js.html">Vue3.js</a></li>
<li><a href="vue3js_v-for.html">Vue3 with v-for</a></li>
<li><a href="web-comp.html">Web Component</a></li>
<li><a href="web1.html">Website demo 1</a></li>
<li><a href="web2.html">Website demo 2</a></li>
Expand Down
6 changes: 3 additions & 3 deletions demo/vue3js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<main id="app">
<h1>How to integrate GridStack.js with Vue.js</h1>
<p>
As with any virtualDOM-based framework, you need to check if Vue has
As with any virtual DOM based framework, you need to check if Vue has
rendered the DOM (or any updates to it) <strong>before</strong> you
initialize GridStack or call its methods. As a basic example, check this
component's <code>mounted</code> hook.
Expand All @@ -35,7 +35,7 @@ <h1>How to integrate GridStack.js with Vue.js</h1>
setup() {
let count = ref(0);
let info = ref("");
let grid = null;
let grid = null; // DO NOT use ref(NULL) as proxies GS will break all logic when comparing structures... see https://github.com/gridstack/gridstack.js/issues/2115
const items = [
{ x: 2, y: 1, h: 2 },
{ x: 2, y: 4, w: 3 },
Expand All @@ -45,7 +45,7 @@ <h1>How to integrate GridStack.js with Vue.js</h1>
];

onMounted(() => {
grid = GridStack.init({
grid = GridStack.init({ // DO NOT user grid.value = GridStack.init(), see above
float: true,
cellHeight: "70px",
minRow: 1,
Expand Down
163 changes: 163 additions & 0 deletions demo/vue3js_v-for.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,163 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vue3 v-for Gridstack</title>
<link rel="stylesheet" href="demo.css"/>
<script src="../dist/gridstack-all.js"></script>
</head>
<body>
<main id="app">
<h1>How to integrate GridStack.js with Vue.js</h1>
<p>
As with any virtual DOM based framework, you need to check if Vue has
rendered the DOM (or any updates to it) <strong>before</strong> you
initialize GridStack or call its methods. As a basic example, check this
component's <code>mounted</code> hook.
</p>
<p>
If your app requires more complex render logic than the inline template
in `addWidget`, consider
<a
href="https://github.com/gridstack/gridstack.js/tree/master/doc#makewidgetel"
>makeWidget</a
>
to let Vue deal with DOM rendering.
</p>
<button type="button" @click="addNewWidget2()">Add Widget pos [0,0]</button>
<button type="button" @click="removeLastWidget()">Remove Last Widget</button>
<br>
<br>
<button type="button" @click="changeFloat()">Float: {{gridFloat}}</button>

<div>{{ info }}</div>
<br>
<div><b :style="{color: color}">{{ gridInfo }}</b></div>
<br>

<div class="grid-stack">
<div v-for="(w, indexs) in items" class="grid-stack-item" :gs-x="w.x" :gs-y="w.y" :gs-w="w.w" :gs-h="w.h" :gs-id="w.id" :id="w.id">
<div class="grid-stack-item-content">
<button @click="remove(w)">remove</button>
{{w}}
</div>
</div>
</div>

</main>
<script type="module">
import { createApp, ref, onMounted, nextTick } from "https://cdn.jsdelivr.net/npm/vue@3.0.11/dist/vue.esm-browser.js";

createApp({
setup() {
let count = ref(0);
let info = ref("");
let gridFloat = ref(false);
let color = ref("black");
let gridInfo = ref("");
let grid = null; // DO NOT use ref(NULL) as proxies GS will break all logic when comparing structures... see https://github.com/gridstack/gridstack.js/issues/2115
let items = ref([]);

onMounted(() => {
grid = GridStack.init({ // DO NOT user grid.value = GridStack.init(), see above
float: false,
cellHeight: "70px",
minRow: 1,
});
grid.on("dragstop", function (event, element) {
const node = element.gridstackNode;
info.value = `you just dragged node #${node.id} to ${node.x},${node.y} – good job!`;
});
grid.on('change', onChange);
// gridFloat.value = grid.float();
});

function changeFloat() {
gridFloat.value = !gridFloat.value;
grid.float(gridFloat.value);
}

function onChange(event, changeItems) {
updateInfo();
// update item position
changeItems.forEach(item => {
var widget = items.value.find(w => w.id == item.id);
if (!widget) {
alert("Widget not found: " + item.id);
return;
}
widget.x = item.x;
widget.y = item.y;
widget.w = item.w;
widget.h = item.h;
});
}


function addNewWidget2() {
const node = items[count.value] || { x: 0, y: 0, w: 2, h: 2 };
node.id = 'w_'+ (count.value++);
// grid.addWidget(node);
items.value.push(node);
nextTick(()=>{
grid.makeWidget(node.id);
updateInfo();
});
}

function removeLastWidget() {
if (count.value == 0) return;
var id = `w_${count.value-1}`;
var index = items.value.findIndex(w => w.id == id);
if (index < 0) return;
var removed = items.value[index];
remove(removed);
}

function remove(widget) {
var index = items.value.findIndex(w => w.id == widget.id);
items.value.splice(index, 1);
const selector = `#${widget.id}`;
grid.removeWidget(selector, false);
updateInfo();
}

function updateInfo() {
color.value = grid.engine.nodes.length == items.value.length ? "black" : "red";
gridInfo.value = `Grid engine: ${grid.engine.nodes.length}, widgets: ${items.value.length}`;

}

return {
info,
items,
addNewWidget2,
removeLastWidget,
onChange,
grid,
gridInfo,
remove,
gridFloat,
changeFloat,
color
};
},

watch: {
/**
* Clear the info text after a two second timeout. Clears previous timeout first.
*/
info: function (newVal) {
if (newVal.length === 0) return;

window.clearTimeout(this.timerId);
this.timerId = window.setTimeout(() => {
this.info = "";
}, 2000);
},
},
}).mount("#app");
</script>
</body>
</html>
8 changes: 6 additions & 2 deletions doc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ Change log
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*

- [7.1.2-dev (2022-12-29)](#712-2022-12-29)
- [7.1.2-dev (TBD)](#712-dev-tbd)
- [7.1.2 (2022-12-29)](#712-2022-12-29)
- [7.1.1 (2022-11-13)](#711-2022-11-13)
- [7.1.0 (2022-10-23)](#710-2022-10-23)
- [7.0.1 (2022-10-14)](#701-2022-10-14)
Expand Down Expand Up @@ -77,7 +78,10 @@ Change log

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

## 7.1.2-dev (2022-12-29)
## 7.1.2-dev (TBD)
* fix [#1936](https://github.com/gridstack/gridstack.js/issues/1936) some styles left behind after a drag

## 7.1.2 (2022-12-29)
* fix [#939](https://github.com/gridstack/gridstack.js/issues/2039) 'prototype' undefined error for dd-gridstack.js
* add [#939](https://github.com/gridstack/gridstack.js/issues/2105) disable/enable are methods now recursive by default
* add better `GridStackEventHandlerCallback` spelled out types
Expand Down