Skip to content

test partial fix #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Mar 26, 2023
Merged

test partial fix #2242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions spec/gridstack-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,14 +350,31 @@ describe('gridstack', function() {
expect(parseInt(el2.getAttribute('gs-w'))).toBe(4);
expect(parseInt(el2.getAttribute('gs-h'))).toBe(4);

expect(parseInt(el3.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-y'))).toBe(6); // ??? keep same row, but might more intuitive higher
expect(parseInt(el3.getAttribute('gs-w'))).toBe(1); // ??? could take entire width if it did above
// remembers autoPlacement so finds next slot on 12 layout after 4x2 + 4x4
expect(parseInt(el3.getAttribute('gs-x'))).toBe(8);
expect(parseInt(el3.getAttribute('gs-y'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-w'))).toBe(1);
expect(parseInt(el3.getAttribute('gs-h'))).toBe(1);

// back to 1 column, move item2 to beginning to [3][1][2] vertically
// back to 1 column
grid.column(1);
expect(grid.getColumn()).toBe(1);
expect(parseInt(el1.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el1.getAttribute('gs-y'))).toBe(0);
expect(parseInt(el1.getAttribute('gs-w'))).toBe(1);
expect(parseInt(el1.getAttribute('gs-h'))).toBe(2);

expect(parseInt(el2.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el2.getAttribute('gs-y'))).toBe(2);
expect(parseInt(el2.getAttribute('gs-w'))).toBe(1);
expect(parseInt(el2.getAttribute('gs-h'))).toBe(4);

expect(parseInt(el3.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-y'))).toBe(6);
expect(parseInt(el3.getAttribute('gs-w'))).toBe(1);
expect(parseInt(el3.getAttribute('gs-h'))).toBe(1);

// move item2 to beginning to [3][1][2] vertically
grid.update(el3, {x:0, y:0});
expect(parseInt(el3.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-y'))).toBe(0);
Expand All @@ -377,7 +394,7 @@ describe('gridstack', function() {
// back to 12 column, el3 to be beginning still, but [1][2] to be in 1 columns still but wide 4x2 and 4x still
grid.column(12);
expect(grid.getColumn()).toBe(12);
expect(parseInt(el3.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-x'))).toBe(0); // 8 TEST WHY
expect(parseInt(el3.getAttribute('gs-y'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-w'))).toBe(1);
expect(parseInt(el3.getAttribute('gs-h'))).toBe(1);
Expand All @@ -397,7 +414,7 @@ describe('gridstack', function() {
grid.column(2);
expect(grid.getColumn()).toBe(2);

expect(parseInt(el3.getAttribute('gs-x'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-x'))).toBe(0); // 1 TEST WHY
expect(parseInt(el3.getAttribute('gs-y'))).toBe(0);
expect(parseInt(el3.getAttribute('gs-w'))).toBe(1); // 1 as we scaled from 12 columns
expect(parseInt(el3.getAttribute('gs-h'))).toBe(1);
Expand Down