Skip to content

Conversation

@ffxsam
Copy link
Contributor

@ffxsam ffxsam commented Apr 22, 2023

Updated SASS code to not used deprecated methods.

Description

Please explain the changes you made here. Include an example of what your changes fix or how to use the changes.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

Updated SASS code to not used deprecated methods.
@adumesny
Copy link
Member

adumesny commented Apr 22, 2023

really it's deprecated now ? that was updated not so long ago to follow https://sass-lang.com/documentation/breaking-changes/slash-div

// RIGHT, will work in future Sass versions.
@debug math.div(12px, 4px); // 3

also you are missing the gridstack.scss and other files if really deprecated.... but it works just fine

@ffxsam
Copy link
Contributor Author

ffxsam commented Apr 23, 2023

Yeah, I got warnings about using those calculations. You could also use math.div, but I found calc() to look cleaner.

I'll make those changes in a sec.

@ffxsam
Copy link
Contributor Author

ffxsam commented Apr 23, 2023

Done!

@leemoria
Copy link

really it's deprecated now ? that was updated not so long ago to follow https://sass-lang.com/documentation/breaking-changes/slash-div

// RIGHT, will work in future Sass versions.
@debug math.div(12px, 4px); // 3

also you are missing the gridstack.scss and other files if really deprecated.... but it works just fine

When the latest version is published? thanks. My angular Project is Wrong

@adumesny
Copy link
Member

@leemoria this has nothing to do with v8 or angular release. please don't cross post.

@@ -1,4 +1,4 @@
# gridstack.js
be# gridstack.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like junk char. will remove...

@adumesny adumesny merged commit 76a78cd into gridstack:master Apr 30, 2023
@ffxsam ffxsam deleted the patch-1 branch April 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants