Skip to content

addWidget() addRemoveCB checks if already initialize widget #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
May 26, 2023
Merged

addWidget() addRemoveCB checks if already initialize widget #2342

adumesny merged 1 commit into from
May 26, 2023

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented May 26, 2023

Description

  • addRemoveCB may have the user call makeWidget() so prevent multiple instances (which oddly created clone nodes) from happening.
  • also makeWidget() (now call form addWidget()) checks for nested grid options. same optimization remains.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
addWidget() addRemoveCB checks if already initialize widget
87a454a 
* addRemoveCB may have the user call makeWidget() so prevent multiple instances (which oddly created clone nodes) from happening.
* also makeWidget() (now call form addWidget()) checks for nested grid options. same optimization remains.
@adumesny adumesny merged commit e44eb1d into gridstack:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adumesny