Skip to content

don't clear (default) attr when dragging outside item in #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Jun 12, 2023
Merged

don't clear (default) attr when dragging outside item in #2362

adumesny merged 1 commit into from
Jun 12, 2023

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Jun 12, 2023

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
don't clear (default) attr when dragging outside item in
8856aab 
* fix gridstack#2354
* external items (like toolbar) might have grid-item attr we want to clone, so don't clear them
@adumesny adumesny merged commit a340857 into gridstack:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

max-w cloning issue

1 participant

@adumesny