Skip to content

Do not remove subgrid when updating widget content #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Jul 9, 2023
Merged

Do not remove subgrid when updating widget content #2386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/gridstack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,10 +1192,16 @@ export class GridStack {

// check for content changing
if (w.content) {
let sub = el.querySelector('.grid-stack-item-content');
if (sub && sub.innerHTML !== w.content) {
sub.innerHTML = w.content;
let toRemove = el.querySelectorAll('.grid-stack-item-content > :not(.grid-stack-nested, style)');
Copy link
Member Author

@adumesny adumesny Jul 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this doesn't work if you have content='foo' instead of content='<div>foo</div>' as in your jsfiddle example

const subGrid = el.querySelector('.grid-stack-item-content > .grid-stack-nested')
const itemContent = el.querySelector('.grid-stack-item-content');
if (toRemove) {
toRemove.forEach(child => itemContent.removeChild(child));
}
const tempEl = document.createElement("div");
tempEl.innerHTML = w.content;
tempEl.childNodes.forEach(childNode => itemContent.insertBefore(childNode, subGrid));

delete w.content;
}

Expand Down