Skip to content

fix(drag): fix mouse drag on devices with touchscreen #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(drag): fix mouse drag on devices with touchscreen #2419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/dd-touch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ export function touchend(e: TouchEvent): void {
*/
export function pointerdown(e: PointerEvent): void {
// console.log("pointer down")
(e.target as HTMLElement).releasePointerCapture(e.pointerId) // <- Important!
if (e.pointerType !== 'mouse') {
(e.target as HTMLElement).releasePointerCapture(e.pointerId) // <- Important!
}
}

export function pointerenter(e: PointerEvent): void {
Expand All @@ -185,7 +187,9 @@ export function pointerenter(e: PointerEvent): void {
return;
}
// console.log('pointerenter');
simulatePointerMouseEvent(e, 'mouseenter');
if (e.pointerType !== 'mouse') {
simulatePointerMouseEvent(e, 'mouseenter');
}
}

export function pointerleave(e: PointerEvent): void {
Expand All @@ -195,10 +199,12 @@ export function pointerleave(e: PointerEvent): void {
// console.log('pointerleave ignored');
return;
}
DDTouch.pointerLeaveTimeout = window.setTimeout(() => {
delete DDTouch.pointerLeaveTimeout;
// console.log('pointerleave delayed');
simulatePointerMouseEvent(e, 'mouseleave');
}, 10);
if (e.pointerType !== 'mouse') {
DDTouch.pointerLeaveTimeout = window.setTimeout(() => {
delete DDTouch.pointerLeaveTimeout;
// console.log('pointerleave delayed');
simulatePointerMouseEvent(e, 'mouseleave');
}, 10);
}
}