Skip to content

fix potential crash in doContentResize() #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Nov 8, 2023
Merged

fix potential crash in doContentResize() #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Change log
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*

- [9.5.0-dev (TBD)](#950-dev-tbd)
- [9.5.0 (2023-10-26)](#950-2023-10-26)
- [9.4.0 (2023-10-15)](#940-2023-10-15)
- [9.3.0 (2023-09-30)](#930-2023-09-30)
Expand Down Expand Up @@ -103,6 +104,10 @@ Change log

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

## 9.5.0-dev (TBD)
* fix [#2525](https://github.com/gridstack/gridstack.js/commit/2525) Fixed unhandled exception happening in _mouseMove handler
* fix potential crash in doContentResize() if grid gets deleted by the time the delay happens

## 9.5.0 (2023-10-26)
* feat [#1275](https://github.com/gridstack/gridstack.js/issues/1275) div scale support - Thank you [elmehdiamlou](https://github.com/elmehdiamlou) for implementing this teh right way (add scale to current code)
* fix [#2489](https://github.com/gridstack/gridstack.js/commit/2489) moved the dropped event handler to after doing everything (no more setTimeout) - Thanks [arnoudb](https://github.com/arnoudb) for suggesting a fix.
Expand Down
1 change: 1 addition & 0 deletions src/gridstack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,6 +1699,7 @@ export class GridStack {
// update any gridItem height with sizeToContent, but wait for DOM $animation_speed to settle if we changed column count
// TODO: is there a way to know what the final (post animation) size of the content will be so we can animate the column width and height together rather than sequentially ?
setTimeout(() => {
if (!this.engine) return; // we've been deleted in between!
if (n) {
if (Utils.shouldSizeToContent(n)) this.resizeToContentCheck(n.el, useAttr);
} else if (this.engine.nodes.some(n => Utils.shouldSizeToContent(n))) {
Expand Down