Skip to content

Conversation

@liqiuqiui
Copy link
Contributor

Description

Add type overloading to the on and off function to obtain better type hints in development. An example is shown in the following figure:

image image image image

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
Copy link
Member

thnaks, this handles the string case as well (might need to make an array option as well).

@adumesny adumesny merged commit dcf5316 into gridstack:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants