Skip to content

recreated grid trash issue #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adumesny merged 1 commit into from
Mar 30, 2024
Merged

recreated grid trash issue #2647

adumesny merged 1 commit into from
Mar 30, 2024

Conversation

@adumesny
Copy link
Member

@adumesny adumesny commented Mar 30, 2024

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
recreated grid trash issue
6b891e3 
* fix gridstack#2453
* make sure _setupRemoveDrop() is static since it is a shared and not per grid
* also bit more optimization during destroy()
@adumesny adumesny merged commit 1c0e975 into gridstack:master Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

removable item was broken when the grid was destroyed and then reinstantiated

1 participant

@adumesny