Add handling of em/rem/px units for cell_height and vertical_margin #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as well as no height option/full CSS heights
src/gridstack.js
Outdated
| this.opts.vertical_margin_unit = heightData.unit; | ||
| this.opts.vertical_margin = heightData.height; | ||
|
|
||
| !noUpdate && this._update_styles(); |
Contributor
There was a problem hiding this comment.
!noUpdate && this._update_styles();
Please, no. We can definitely bear one more line to increase readability. ;)
Author
|
Better? :) |
troolee
added a commit
that referenced
this pull request
Feb 16, 2016
Add handling of em/rem/px units for cell_height and vertical_margin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of em/rem/px units for cell_height and vertical_margin as well as no cell_height option/full CSS heights.
The point is mostly to be able to work with "em" sizes.
See changes in README for details.