Min height fix #775
Merged
Min height fix #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing:
1. run two.html and check that yellow grid has height of 300px
2. modify two.html to have
#grid1 {
background: lightgoldenrodyellow;
min-height: 300px;
}
3. rerun and notice grid1 now has 380px actual height (passed last item) !
4. adding removing items will shrink grow, but not to the correct min 300px size.
Testing:
1. run two.html and check that yellow grid has height of 300px
2. modify two.html to have
#grid1 {
background: lightgoldenrodyellow;
min-height: 300px;
}
3. rerun and notice grid1 now has 380px actual height (passed last item) !
4. adding removing items will shrink grow, but not to the correct min 300px size.
… minHeight_fix # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
adumesny
commented
Sep 13, 2017
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/gridstack/gridstack.js.git" | ||
| }, |
Member
Author
There was a problem hiding this comment.
added an explicit lint (makes it easier to check before commit) as for some reason it's not auto linting in Visual Studio code yet...
adumesny
commented
Sep 13, 2017
| var minHeight = parseInt(this.container.css('min-height')) / this.cellHeight(); | ||
| if (height < minHeight) { | ||
| height = minHeight; | ||
| // check for css min height. Each row is cellHeight + verticalMargin, until last one which has no margin below |
Member
Author
There was a problem hiding this comment.
real change - ignore the /dist files as they will be removed yet (merge hell)
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use verticalMargin when calculating min height in rows
Testing:
#grid1 {
background: lightgoldenrodyellow;
min-height: 300px;
}