remove dist/ #777
Merged
remove dist/ #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 13, 2017 10:23
…o conflict on merge or issue being out of sync. use 'build' target to generate before publishing npm (which I didn't see included) Bug Number: #776
…o conflict on merge or issue being out of sync. use 'build' target to generate before publishing npm (which I didn't see included) Bug Number: #776
…to 776_dist_remove
adumesny
commented
Sep 14, 2017
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "build": "grunt ; doctoc ./README.md ; doctoc ./doc/README.md ; doctoc ./doc/CHANGES.md", | ||
| "build": "mkdir dist && grunt && doctoc ./README.md && doctoc ./doc/README.md && doctoc ./doc/CHANGES.md", |
Member
Author
There was a problem hiding this comment.
&& are needed to run on windows instead of ;
There was a problem hiding this comment.
mkdir dist will fail if dist exists. You can pass mkdir -p to only create it if it does not exist
There was a problem hiding this comment.
looks like -p is only supported on *nix versions of the utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove dist/ folder and instead generate the output files during build process, so there is no conflict on merge or issue being out of sync.
use 'build' target to generate before publishing npm (which I didn't see included)
fix #776