Bug wrong maxHeight for updateStyles function #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are 4 row of grid items and more. There are bug of updates styles. The function does not take into account all nodes, but only those that have been changed (_dirty). In this regard, the styles for the lower layers do not sink, and they rise upward. The solution is to calculate the maxHeight for all nodes.
forgot the bracket close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are 4 row of grid items and more. There are bug of updates styles.
The function does not take into account all nodes, but only those that have been changed (_dirty).
In this regard, the styles for the lower layers do not sink, and they rise upward.
The solution is to calculate the maxHeight for all nodes.
Bug example - https://youtu.be/1bZQIaZqVLQ