issue-805 - fix node being added to grid more than once after being dragged out of bounds #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ragged out of bounds
Contributor
Author
|
Why does this fail? |
Member
|
@roborto444 don't worry. We'll get more code coverage soon, but for the time being, a 0.07% drop is perfectly acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frequent Transient Bug when moving or resizing
issue-805 - fix node being added to grid more than once after being dragged out of bounds
Description of issue
After a grid item was dragged out of bounds there were extra node being added to the grid. This caused the node to get stuck.
See video: https://youtu.be/QJj6hi7lnDU.
Solution:
Node only gets re-added once, after being dragged out of bounds. Set "node._temporaryRemoved" to false when adding node back into grid the first time. This prevents multiple calls to addNode().